From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Jeff King <peff@peff.net>, Kevin Menard <nirvdrum@gmail.com>,
git@vger.kernel.org
Subject: Re: git fetch origin hanging in 1.7.0
Date: Tue, 16 Feb 2010 14:27:59 +0200 [thread overview]
Message-ID: <20100216122759.GA30898@Knoppix> (raw)
In-Reply-To: <20100216151821.994ace31.rctay89@gmail.com>
On Tue, Feb 16, 2010 at 03:18:21PM +0800, Tay Ray Chuan wrote:
> NAK. This will only work if the given transport is git://. (My take
> below.)
>
>
> -- >8 --
> Subject: [PATCH] transport: add got_remote_refs flag
>
> tranport.c::transport_get_remote_refs() used to check
> transport->remote_refs to determine whether transport->get_refs_list()
> should be invoked.
>
> However, transport->remote_refs could evaluate to false (eg. if it is
> NULL), causingo transport->get_refs_list() to be invoked unnecessarily.
>
> Introduce a flag, transport->got_remote_refs, and make
> tranport.c::transport_get_remote_refs() check this flag rather than
> evaluating transport->remote_refs.
<snip patch>
Seems to work even in external transport case (not suprising, as at this
level, there's no difference between git://, ssh://, file:// and external
transports).
-Ilari
prev parent reply other threads:[~2010-02-16 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 0:08 git fetch origin hanging in 1.7.0 Kevin Menard
2010-02-16 6:39 ` Jeff King
2010-02-16 7:18 ` Tay Ray Chuan
2010-02-16 7:24 ` Jeff King
2010-02-16 7:32 ` Tay Ray Chuan
2010-02-16 13:20 ` Kevin Menard
2010-02-16 12:27 ` Ilari Liusvaara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216122759.GA30898@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=nirvdrum@gmail.com \
--cc=peff@peff.net \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).