git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Avery Pennarun <apenwarr@gmail.com>,
	Ben Gamari <bgamari@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Storing (hidden) per-commit metadata
Date: Sun, 21 Feb 2010 03:52:37 -0500	[thread overview]
Message-ID: <20100221085237.GA31189@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1002210945490.20986@pacific.mpi-cbg.de>

On Sun, Feb 21, 2010 at 09:49:28AM +0100, Johannes Schindelin wrote:

> > If the only problem is that the data is ugly in "git show", then perhaps 
> > we need a "suppress these pseudo-headers" feature for showing logs. It 
> > keeps them easily available for inspection or for --grep, but most of 
> > the time you would not see them.
> 
> Whoa. Even more processing to do for each commit during a "git log" run? 
> You know, other people are working on _accelerating_ git log as we speak!

I think this is premature.  You would not need to pay the price for such
a feature if you were not actually using it. On top of which, as it does
not yet exist, it has not actually been benchmarked. So any complaints
should wait until it is actually implemented.

> And really, while I can understand that the OP wanted to hide the 
> information, I am really against that. For example, when I see a log with 
> git-svn footers, it gives me _additional_ information which I actually 
> like (it tells me where these commits really come from). If they do not 
> need bidirectional, they can skip those footers.

I think it depends on what the information is, which I'm still not clear
on. But most importantly, I think it makes sense to put control of
whether that information is seen in the hands of the user who is
invoking git.

-Peff

PS I tried to keep this message short. Short enough? :)

  reply	other threads:[~2010-02-21  8:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 17:11 Storing (hidden) per-commit metadata Jelmer Vernooij
2010-02-20 17:41 ` Ben Gamari
2010-02-20 18:57   ` Avery Pennarun
2010-02-21  6:34     ` Jeff King
2010-02-21  8:49       ` Johannes Schindelin
2010-02-21  8:52         ` Jeff King [this message]
2010-02-21 12:17       ` Jelmer Vernooij
2010-02-22  5:17         ` Dmitry Potapov
2010-02-22  9:56           ` Jelmer Vernooij
2010-02-22 11:28             ` Dmitry Potapov
2010-02-22 11:59               ` Jelmer Vernooij
2010-02-22 13:08                 ` Dmitry Potapov
2010-02-22 13:44                   ` Jelmer Vernooij
2010-02-22 14:20                     ` Dmitry Potapov
2010-02-22 19:13                       ` Jelmer Vernooij
2010-02-22 14:57       ` Jelmer Vernooij
2010-02-22  5:11 ` Gabriel Filion
2010-02-22  9:49   ` Jelmer Vernooij
2010-02-22 22:13 ` "Alejandro R. Sedeño"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100221085237.GA31189@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=apenwarr@gmail.com \
    --cc=bgamari@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).