From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
Robert Shearman <robertshearman@gmail.com>,
Ben Walton <bwalton@artsci.utoronto.ca>
Subject: Re: [PATCH] Disable OpenSSL SHA1 implementation by default
Date: Mon, 22 Feb 2010 06:23:26 -0500 [thread overview]
Message-ID: <20100222112326.GA21929@coredump.intra.peff.net> (raw)
In-Reply-To: <20100222110814.GA3247@progeny.tock>
On Mon, Feb 22, 2010 at 05:08:14AM -0600, Jonathan Nieder wrote:
> The OpenSSL SHA-1 routine is about as fast as block-sha1, but linking
> to libcrypto slows down the startup of git commands by an appreciable
> amount. Use the BLK_SHA1 implementation by default instead.
What is your definition of "about as fast"? I benchmarked up to a 20%
slow-down a while back:
http://article.gmane.org/gmane.comp.version-control.git/126995
Now my complaint then was specifically about removing openssl sha1
support entirely, and I have no problem with setting OPENSSL_SHA1 in my
build options, but it does make sense to me that the default should
be whatever is fastest for most people. And that means benchmarking
blk_sha1 versus the libcrypto linking slow-down on several machines to
get actual numbers.
Unfortunately, I think we may end up with an apples-to-oranges
comparison, as sha1-heavy tasks are affected one way, and scripted
many-git-invocation tasks the other way.
> Typed “make NO_OPENSSL=1” for the umpteenth time today, but this time
> I thought I should something about it.
echo 'NO_OPENSSL=1' >config.mak ?
> -ifndef NO_OPENSSL
> +ifdef OPENSSL_TLS
> + BASIC_CFLAGS += -DOPENSSL_TLS
> + USE_OPENSSL = Yes
> +endif
Doesn't this flip the default for using TLS on imap-send?
-Peff
next prev parent reply other threads:[~2010-02-22 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 11:08 [PATCH] Disable OpenSSL SHA1 implementation by default Jonathan Nieder
2010-02-22 11:23 ` Jeff King [this message]
2010-02-22 11:55 ` Jonathan Nieder
2010-02-26 4:11 ` Mark Lodato
2010-02-26 9:36 ` Jeff King
2010-02-26 21:33 ` Mark Lodato
2010-02-26 22:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222112326.GA21929@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=nico@fluxnic.net \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).