From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Teemu Matilainen <teemu.matilainen@iki.fi>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/2] bash: Enable completion for external subcommands
Date: Tue, 23 Feb 2010 16:50:07 +0100 [thread overview]
Message-ID: <20100223155007.GB10772@neumann> (raw)
In-Reply-To: <1266936193-10644-1-git-send-email-teemu.matilainen@iki.fi>
Hi,
On Tue, Feb 23, 2010 at 04:43:12PM +0200, Teemu Matilainen wrote:
> Now the parameter completion is only available for subcommands
> delivered with git. Providers of external subcommands do not have
> a way to supply bash completion for their commands (other than
> instructing users to hack their git-completion.bash file).
>
> This makes it possible to have completion also for external git
> subcommands. It can be provided by specifying a function (or a
> command in PATH) '_git_<subcommand>' that sets the environment
> variable COMPREPLY.
>
> All dashes (-) in the subcommand name are replaced with underscores
> (_). E.g. completion for command 'git foo-bar' can be provided by
> '_git_foo_bar'.
>
> Signed-off-by: Teemu Matilainen <teemu.matilainen@iki.fi>
this issue was raised a few weeks ago, and the discussion led to a
similar patch back then. However, Junio mentioned a few concerns
regarding this approach, and, since it was v1.7.0-rc time and this was
clearly a post v1.7.0 change, I didn't pursue the discussion and
didn't send updated patches, and then forgot it completely. I will
try to find some time in the evening to get the commit messages in
shape send out the updates. In the meantime please have a look at
Junio's concerns about this approach:
http://thread.gmane.org/gmane.comp.version-control.git/138316/focus=138348
Best,
Gábor
next prev parent reply other threads:[~2010-02-23 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 14:43 [PATCH 1/2] bash: Enable completion for external subcommands Teemu Matilainen
2010-02-23 14:43 ` [PATCH 2/2] bash: Use dynamic binding for subcommand completion functions Teemu Matilainen
2010-02-23 15:50 ` SZEDER Gábor [this message]
2010-02-23 16:02 ` [PATCH 1/2] bash: Enable completion for external subcommands Teemu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223155007.GB10772@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=teemu.matilainen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).