From: Teemu Matilainen <teemu.matilainen@iki.fi>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/2] bash: Enable completion for external subcommands
Date: Tue, 23 Feb 2010 18:02:30 +0200 [thread overview]
Message-ID: <20100223160230.GB837@reaktor.fi> (raw)
In-Reply-To: <20100223155007.GB10772@neumann>
On Tue, 23 Feb 2010, SZEDER Gábor wrote:
> On Tue, Feb 23, 2010 at 04:43:12PM +0200, Teemu Matilainen wrote:
> > This makes it possible to have completion also for external git
> > subcommands.
>
> this issue was raised a few weeks ago, and the discussion led to a
> similar patch back then. However, Junio mentioned a few concerns
> regarding this approach, and, since it was v1.7.0-rc time and this was
> clearly a post v1.7.0 change, I didn't pursue the discussion and
> didn't send updated patches, and then forgot it completely. I will
> try to find some time in the evening to get the commit messages in
> shape send out the updates. In the meantime please have a look at
> Junio's concerns about this approach:
> http://thread.gmane.org/gmane.comp.version-control.git/138316/focus=138348
Ugh. I *tried* to search the mailing list, but apparently failed...
Funny that anyway we got almost identical solution.
Thanks for the pointer. I'll be waiting for the new patch.
--
- Teemu
prev parent reply other threads:[~2010-02-23 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 14:43 [PATCH 1/2] bash: Enable completion for external subcommands Teemu Matilainen
2010-02-23 14:43 ` [PATCH 2/2] bash: Use dynamic binding for subcommand completion functions Teemu Matilainen
2010-02-23 15:50 ` [PATCH 1/2] bash: Enable completion for external subcommands SZEDER Gábor
2010-02-23 16:02 ` Teemu Matilainen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223160230.GB837@reaktor.fi \
--to=teemu.matilainen@iki.fi \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).