From: Heiko Voigt <hvoigt@hvoigt.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7
Date: Tue, 23 Feb 2010 23:52:45 +0100 [thread overview]
Message-ID: <20100223225243.GC11271@book.hvoigt.net> (raw)
It seems that Windows 7's explorer is not capable to cope with paths
that contain forward slashes as path seperator. We thus substitute slash
with the platforms native backslash.
Signed-off-by: Heiko Voigt <heiko.voigt@mahr.de>
---
git-gui/git-gui.sh | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 9a9525d..ae45a12 100644
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -2112,15 +2112,17 @@ proc do_git_gui {} {
proc do_explore {} {
global _gitworktree
set explorer {}
+ set path $_gitworktree
if {[is_Cygwin] || [is_Windows]} {
set explorer "explorer.exe"
+ set path [list [string map {/ \\} $path]]
} elseif {[is_MacOSX]} {
set explorer "open"
} else {
# freedesktop.org-conforming system is our best shot
set explorer "xdg-open"
}
- eval exec $explorer $_gitworktree &
+ eval exec $explorer $path &
}
set is_quitting 0
--
1.7.0.m5.rc2.15.g8ba4c
next reply other threads:[~2010-02-23 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:52 Heiko Voigt [this message]
2010-02-24 0:14 ` [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Markus Heidelberg
2010-02-24 6:22 ` Giuseppe Bilotta
2010-02-24 12:12 ` [msysGit] " Pat Thoyts
2010-02-25 0:14 ` [PATCH] git-gui: fix "Explore Working Copy" for Windows again Markus Heidelberg
2010-02-25 20:44 ` Heiko Voigt
2010-02-25 23:00 ` Pat Thoyts
2010-02-26 0:46 ` Johannes Schindelin
2010-02-27 21:14 ` Heiko Voigt
2010-02-24 12:15 ` [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Pat Thoyts
2010-02-25 20:30 ` Heiko Voigt
2010-02-25 22:23 ` [msysGit] " Markus Heidelberg
2010-02-25 22:49 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223225243.GC11271@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).