[PATCH] commit: quote the user name in the example

[PATCH] commit: quote the user name in the example

[Matt Kraai]

If the user runs

 git config --global user.name Your Name

as suggested, user.name will be set to "Your".  With this patch, the
suggested command will be

 git config --global user.name 'Your Name'

which will set user.name to "Your Name" and hopefully help users avoid
the former mistake.

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
---
 builtin-commit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin-commit.c b/builtin-commit.c
index 55676fd..1ec89d1 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -41,7 +41,7 @@ static const char implicit_ident_advice[] =
 "on your username and hostname. Please check that they are accurate.\n"
 "You can suppress this message by setting them explicitly:\n"
 "\n"
-"    git config --global user.name Your Name\n"
+"    git config --global user.name 'Your Name'\n"
 "    git config --global user.email you@example.com\n"
 "\n"
 "If the identity used for this commit is wrong, you can fix it with:\n"
-- 
1.7.0

Re: [PATCH] commit: quote the user name in the example

[Junio C Hamano]

Thanks; will queue for 'maint'.

Re: [PATCH] commit: quote the user name in the example

[Johannes Sixt]

Matt Kraai schrieb:
> If the user runs
> 
>  git config --global user.name Your Name
> 
> as suggested, user.name will be set to "Your".  With this patch, the
> suggested command will be
> 
>  git config --global user.name 'Your Name'
> 
> which will set user.name to "Your Name" and hopefully help users avoid
> the former mistake.

Actually, I would prefer that the suggested command is

  git config --global user.name "Your Name"

i.e., with double-quotes, because then the suggestion is also correct for
Windows users who run git from CMD: in this environment, single-quotes do
not quote, but double-quotes do.

-- Hannes

[PATCH] commit: quote the user name in the example

[Matt Kraai]

If the user runs

 git config --global user.name Your Name

as suggested, user.name will be set to "Your".  With this patch, the
suggested command will be

 git config --global user.name "Your Name"

which will set user.name to "Your Name" and hopefully help users avoid
the former mistake.

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
---
 builtin-commit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin-commit.c b/builtin-commit.c
index 55676fd..46513bf 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -41,7 +41,7 @@ static const char implicit_ident_advice[] =
 "on your username and hostname. Please check that they are accurate.\n"
 "You can suppress this message by setting them explicitly:\n"
 "\n"
-"    git config --global user.name Your Name\n"
+"    git config --global user.name \"Your Name\"\n"
 "    git config --global user.email you@example.com\n"
 "\n"
 "If the identity used for this commit is wrong, you can fix it with:\n"
-- 
1.7.0

Re: [PATCH] commit: quote the user name in the example

[Matt Kraai]

On Wed, Feb 24, 2010 at 08:49:23AM +0100, Johannes Sixt wrote:
> Actually, I would prefer that the suggested command is
> 
>   git config --global user.name "Your Name"
> 
> i.e., with double-quotes, because then the suggestion is also correct for
> Windows users who run git from CMD: in this environment, single-quotes do
> not quote, but double-quotes do.

I've justed submitted a modified version of the patch that uses
double-quotes.  Thanks for the suggestion.

-- 
Matt                                            http://ftbfs.org/kraai