From: David Aguilar <davvid@gmail.com>
To: Frank Li <lznuaa@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 1/1] Use GIT_ASKPASS environment to launch thirdpart UI app to get password
Date: Thu, 25 Feb 2010 01:15:01 -0800 [thread overview]
Message-ID: <20100225091500.GB2903@gmail.com> (raw)
In-Reply-To: <1976ea661002240013j164fc875o469c0dcdf74afe0c@mail.gmail.com>
On Wed, Feb 24, 2010 at 04:13:01PM +0800, Frank Li wrote:
>
> > Many users already have SSH_ASKPASS defined. It would be very
> > nice if we supported SSH_ASKPASS as a fallback when GIT_ASKPASS
> > is not provided.
> >
>
> I consider add such fallback at git.c. when user use git svn, git
> main program will be called firstly.
> git main entry will check if GIT_ASKPASS and SSH_ASKPASS, if
> SSH_ASKPASS set but GIT_ASKPASS not set,
> GIT_ASKPASS will be set as SSH_ASKPASS.
>
> Do you think we needs add such check at git-svn.perl ?
>
> best regards
> Frank Li
Interesting question. I had never thought of moving the
fallback to git.
I would have done it in the script as a localized fix but
I definately see the value in aiding scripts from
all having to implement this same fallback, though:
$ENV{GIT_ASKPASS} ||= $ENV{SSH_ASKPASS};
If Junio, Eric, and the git list think that this should
live in git instead then by all means.
--
David
next prev parent reply other threads:[~2010-02-25 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 11:11 [PATCH 1/1] Use GIT_ASKPASS environment to launch thirdpart UI app to get password Frank Li
2010-02-23 23:31 ` Laszlo Papp
2010-02-24 5:13 ` David Aguilar
2010-02-24 5:31 ` Junio C Hamano
2010-02-24 8:13 ` Frank Li
2010-02-25 9:15 ` David Aguilar [this message]
2010-02-25 17:15 ` Laszlo Papp
2010-02-26 0:15 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225091500.GB2903@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lznuaa@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).