* [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
@ 2010-02-25 10:39 Johannes Sixt
2010-02-25 11:31 ` Johan Herland
2010-02-25 16:42 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Johannes Sixt @ 2010-02-25 10:39 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, Johan Herland
From: Johannes Sixt <j6t@kdbg.org>
This is required on Windows because git-notes is now a built-in
rather than a shell script.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
t/t3301-notes.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 90178f9..37b9687 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -8,6 +8,7 @@ test_description='Test commit notes'
. ./test-lib.sh
cat > fake_editor.sh << \EOF
+#!/bin/sh
echo "$MSG" > "$1"
echo "$MSG" >& 2
EOF
--
1.7.0.1285.g1a907.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
2010-02-25 10:39 [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh Johannes Sixt
@ 2010-02-25 11:31 ` Johan Herland
2010-02-25 16:42 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Johan Herland @ 2010-02-25 11:31 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Junio C Hamano, Git Mailing List
On Thursday 25 February 2010, Johannes Sixt wrote:
> From: Johannes Sixt <j6t@kdbg.org>
>
> This is required on Windows because git-notes is now a built-in
> rather than a shell script.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Johan Herland <johan@herland.net>
--
Johan Herland, <johan@herland.net>
www.herland.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
2010-02-25 10:39 [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh Johannes Sixt
2010-02-25 11:31 ` Johan Herland
@ 2010-02-25 16:42 ` Junio C Hamano
2010-02-25 20:17 ` Johannes Sixt
1 sibling, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2010-02-25 16:42 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Git Mailing List, Johan Herland
Johannes Sixt <j.sixt@viscovery.net> writes:
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index 90178f9..37b9687 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -8,6 +8,7 @@ test_description='Test commit notes'
> . ./test-lib.sh
>
> cat > fake_editor.sh << \EOF
> +#!/bin/sh
> echo "$MSG" > "$1"
> echo "$MSG" >& 2
> EOF
Thanks.
Shouldn't that be "#!$SHELL_PATH", though?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
2010-02-25 16:42 ` Junio C Hamano
@ 2010-02-25 20:17 ` Johannes Sixt
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Sixt @ 2010-02-25 20:17 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, Johan Herland
Junio C Hamano schrieb:
> Shouldn't that be "#!$SHELL_PATH", though?
It doesn't matter, but the change would be larger because we do not
want to expand $MSG.
-- Hannes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-25 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 10:39 [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh Johannes Sixt
2010-02-25 11:31 ` Johan Herland
2010-02-25 16:42 ` Junio C Hamano
2010-02-25 20:17 ` Johannes Sixt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).