From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] Disable OpenSSL SHA1 implementation by default Date: Fri, 26 Feb 2010 17:40:11 -0500 Message-ID: <20100226224011.GB24370@sigill.intra.peff.net> References: <20100222110814.GA3247@progeny.tock> <20100222112326.GA21929@coredump.intra.peff.net> <20100226093633.GA9609@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Jonathan Nieder , git@vger.kernel.org, Nicolas Pitre , Robert Shearman , Ben Walton To: Mark Lodato X-From: git-owner@vger.kernel.org Fri Feb 26 23:40:31 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nl8rG-0003SD-Dv for gcvg-git-2@lo.gmane.org; Fri, 26 Feb 2010 23:40:30 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966472Ab0BZWkP (ORCPT ); Fri, 26 Feb 2010 17:40:15 -0500 Received: from peff.net ([208.65.91.99]:58101 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966347Ab0BZWkN (ORCPT ); Fri, 26 Feb 2010 17:40:13 -0500 Received: (qmail 5478 invoked by uid 107); 26 Feb 2010 22:40:30 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.40) with ESMTPA; Fri, 26 Feb 2010 17:40:30 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 26 Feb 2010 17:40:11 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Feb 26, 2010 at 04:33:23PM -0500, Mark Lodato wrote: > > Which is almost a 12% speedup by dropping openssl. > > I got about an 8% speedup on this test. Thanks for more data. It looks like the patch is probably a win for me (depending on how you slice the workload), and definitely a win for you, then. So probably it is a sane thing to change the default. I suspect the reason I got more of a speedup for "make test" is that I don't do the svn or cvs tests, both of which are really slow and won't be improved by the patch. If you have either installed, then that is diluting your speedup. -Peff