From: Jeff King <peff@peff.net>
To: Mark Lodato <lodatom@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Allow explicit ANSI codes for colors
Date: Sat, 27 Feb 2010 03:51:45 -0500 [thread overview]
Message-ID: <20100227085144.GD27191@coredump.intra.peff.net> (raw)
In-Reply-To: <1267246670-19118-2-git-send-email-lodatom@gmail.com>
On Fri, Feb 26, 2010 at 11:57:46PM -0500, Mark Lodato wrote:
> Allow explicit ANSI codes to be used in configuration options expecting
> a color. The form is "[...m", where "..." are characters in the ASCII
> range 0x30 to 0x3f. This allows users to specify more complex colors
> (generically, SGR attributes) than our color language allows. For
> example, to get blinking, bold, underlined, italic, red text,
> use "[5;1;4;3;31m".
I am not against this patch if it gets us some flexibility that is not
otherwise easy to attain, but wouldn't it be more user friendly for us
to support "red blink bold ul italic"? AFAICT, the only things standing
the way of that are:
- we don't support the italic attribute yet (are there are a lot of
others that we are missing?)
- the parser in color_parse_mem already understands how to parse
multiple attributes, but it just complains after the first one
-Peff
next prev parent reply other threads:[~2010-02-27 8:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 4:57 [PATCH 0/5] color enhancements, particularly for grep Mark Lodato
2010-02-27 4:57 ` [PATCH 1/5] Allow explicit ANSI codes for colors Mark Lodato
2010-02-27 8:51 ` Jeff King [this message]
2010-02-27 18:24 ` Mark Lodato
2010-02-27 21:21 ` Junio C Hamano
2010-02-28 2:56 ` [PATCH] color: allow multiple attributes Junio C Hamano
2010-02-28 12:20 ` Jeff King
2010-02-28 18:16 ` Junio C Hamano
2010-02-28 18:33 ` Jeff King
2010-02-27 4:57 ` [PATCH 2/5] Add GIT_COLOR_BOLD_* and GIT_COLOR_BG_* Mark Lodato
2010-02-27 4:57 ` [PATCH 3/5] Remove reference to GREP_COLORS from documentation Mark Lodato
2010-02-27 4:57 ` [PATCH 4/5] grep: Colorize filename, line number, and separator Mark Lodato
2010-02-27 11:43 ` René Scharfe
2010-02-28 20:14 ` Mark Lodato
2010-02-28 22:26 ` Michael Witten
2010-03-02 1:49 ` Mark Lodato
2010-03-02 6:43 ` Michael Witten
2010-03-03 4:26 ` Mark Lodato
2010-03-03 4:49 ` Miles Bader
2010-02-27 11:53 ` René Scharfe
2010-02-27 17:08 ` Junio C Hamano
2010-02-28 20:15 ` Mark Lodato
2010-02-28 19:29 ` Junio C Hamano
2010-02-28 20:39 ` Mark Lodato
2010-02-27 4:57 ` [PATCH 5/5] grep: Colorize selected, context, and function lines Mark Lodato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227085144.GD27191@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=lodatom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).