From: Heiko Voigt <hvoigt@hvoigt.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: msysGit Mailinglist <msysgit@googlegroups.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: Re: Re: git gui create desktop icon currently does not work
Date: Sat, 27 Feb 2010 21:41:11 +0100 [thread overview]
Message-ID: <20100227204108.GA33000@book.hvoigt.net> (raw)
In-Reply-To: <cb7bb73a1002242353h739786bdlb2c57df3438f5b7f@mail.gmail.com>
On Thu, Feb 25, 2010 at 08:53:57AM +0100, Giuseppe Bilotta wrote:
> On Wed, Feb 24, 2010 at 12:02 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > On Tue, Feb 23, 2010 at 11:54:40PM +0100, Giuseppe Bilotta wrote:
> >> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
[...]
> >> > - [file normalize [$_gitworktree]]
> >> > + [file normalize $_gitworktree]
> >> > } err]} {
> >> > error_popup [strcat [mc "Cannot write shortcut:"] "\n\n$err"]
> >> > }
> >>
> >> Ouch. Yes, I think your patch is obviously correct.
> >>
> >> (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)
> >
> > No problem obviously nobody else saw this, but please test your patches
> > in the future. That could have avoided this one.
>
> You're right, although finding a Windows installation on which to test
> git is nontrivial for me. (I did mention this particular part was
> untested when I submitted it.)
Ok then we can not blame you. Maybe send such a patch to the msysgit
mailinglist and me CC then we can test early.
> > One thing which is missing from my patch is the cygwin part which, as I
> > saw from your original patch, has the same problem.
>
> Also, I'm wondering: does the Windows part actually need a [file
> nativename $_gitworktree], or is this automatically handled by the
> shortcut creation code?
I investigated further and it seems that the cygwin part needs it. I
prepared a patchseries about this and some more issues I will send out
shortly.
cheers Heiko
next prev parent reply other threads:[~2010-02-27 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:49 git gui create desktop icon currently does not work Heiko Voigt
2010-02-23 22:54 ` Giuseppe Bilotta
2010-02-23 23:02 ` Heiko Voigt
2010-02-25 7:53 ` Giuseppe Bilotta
2010-02-27 20:41 ` Heiko Voigt [this message]
2010-02-27 20:45 ` [PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows Heiko Voigt
2010-02-27 20:47 ` [PATCH 2/3] git-gui: fix PATH environment for mingw development environment Heiko Voigt
2010-02-28 0:57 ` [msysGit] " Pat Thoyts
2010-02-28 12:46 ` Heiko Voigt
2010-02-27 20:48 ` [PATCH 3/3] git-gui: fix shortcut creation on cygwin Heiko Voigt
2010-03-08 11:17 ` [PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows Johannes Schindelin
2010-02-27 22:09 ` Re: Re: git gui create desktop icon currently does not work Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227204108.GA33000@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).