From: Heiko Voigt <hvoigt@hvoigt.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: msysGit Mailinglist <msysgit@googlegroups.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: [PATCH 3/3] git-gui: fix shortcut creation on cygwin
Date: Sat, 27 Feb 2010 21:48:48 +0100 [thread overview]
Message-ID: <20100227204848.GD33000@book.hvoigt.net> (raw)
In-Reply-To: <20100227204549.GB33000@book.hvoigt.net>
When the user tried to create a desktop icon with git gui on cygwin
wscript was complaining about an unknown option and displaying the
non-native path as such.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
git-gui/lib/win32.tcl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-gui/lib/win32.tcl b/git-gui/lib/win32.tcl
index d7f93d0..db91ab8 100644
--- a/git-gui/lib/win32.tcl
+++ b/git-gui/lib/win32.tcl
@@ -18,9 +18,9 @@ proc win32_create_lnk {lnk_path lnk_exec lnk_dir} {
eval [list exec wscript.exe \
/E:jscript \
/nologo \
- [file join $oguilib win32_shortcut.js] \
+ [file nativename [file join $oguilib win32_shortcut.js]] \
$lnk_path \
- [file join $oguilib git-gui.ico] \
+ [file nativename [file join $oguilib git-gui.ico]] \
$lnk_dir \
$lnk_exec] $lnk_args
}
--
1.7.0.m5.rc3.5.g38df2
next prev parent reply other threads:[~2010-02-27 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:49 git gui create desktop icon currently does not work Heiko Voigt
2010-02-23 22:54 ` Giuseppe Bilotta
2010-02-23 23:02 ` Heiko Voigt
2010-02-25 7:53 ` Giuseppe Bilotta
2010-02-27 20:41 ` Heiko Voigt
2010-02-27 20:45 ` [PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows Heiko Voigt
2010-02-27 20:47 ` [PATCH 2/3] git-gui: fix PATH environment for mingw development environment Heiko Voigt
2010-02-28 0:57 ` [msysGit] " Pat Thoyts
2010-02-28 12:46 ` Heiko Voigt
2010-02-27 20:48 ` Heiko Voigt [this message]
2010-03-08 11:17 ` [PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows Johannes Schindelin
2010-02-27 22:09 ` Re: Re: git gui create desktop icon currently does not work Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227204848.GD33000@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).