Google Gerrit

Google Gerrit

[Anca Emanuel]

Hi, what do you think about Google Gerrit ? http://code.google.com/p/gerrit/

see it in action here: http://review.source.android.com

quote:
"Gerrit is a web based code review system, facilitating online code
reviews for projects using the Git version control system.
Gerrit makes reviews easier by showing changes in a side-by-side
display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any
authorized user to submit changes to the master Git repository, rather
than requiring all approved changes to be merged in by hand by the
project maintainer. This functionality enables a more centralized
usage of Git."

git needs an friendly UI, web based is the future.

Maybe an integration with Wave.

Re: Google Gerrit

[Shawn O. Pearce]

Anca Emanuel <anca.emanuel@gmail.com> wrote:
> Hi, what do you think about Google Gerrit ? http://code.google.com/p/gerrit/
> 
> see it in action here: http://review.source.android.com

For kernel or at least C-ish folk... a kernel patch under development
might be more relevant to point to.  E.g.:

https://review.source.android.com/13610
 
> quote:
> "Gerrit is a web based code review system, facilitating online code
> reviews for projects using the Git version control system.
> Gerrit makes reviews easier by showing changes in a side-by-side
> display, and allowing inline comments to be added by any reviewer.
> Gerrit simplifies Git based project maintainership by permitting any
> authorized user to submit changes to the master Git repository, rather
> than requiring all approved changes to be merged in by hand by the
> project maintainer. This functionality enables a more centralized
> usage of Git."

I hate that description.  I keep meaning to overhaul the project
landing page with screenshots and try to describe the feature set
better, but I've been too busy with coding.
 
> git needs an friendly UI, web based is the future.

We have a number of UIs for Git... some more user friendly to
certain classes of users than others.  But I'm not sold that a
web based interface is the future.

Sometimes a web UI can be very convient to work with.  Sometimes, the
existing mailing list review infrastructure works very well.  What I
love most about Git is how much choice we really have as users.
 
> Maybe an integration with Wave.

Maybe.  But I'm not actively pursuing that right now.  If someone
else develops a Gitty bot for Wave, that would be cool.

Actually... my goal over the next couple of months here is to
make Gerrit Code Review no longer dependent on a web UI, or on a
backend SQL database.  I'm going to shift all of the data storage
into Git meta branches, and the code annotations into Git notes.
Which will make it very friendly to build other tools like an Emacs
plugin that can interoperate based solely on raw Git commands and
formats, without ever touching the existing Java or web UI.

I think the biggest challenge I have is I need a good inverted
search index, and Git has no standard for that.  I'm tempted to
use Apache Lucene[1] because in Java its simple to work with,
but their C port has been dangling in the wind for a long time.

[1] http://lucene.apache.org/

-- 
Shawn.

Re: Google Gerrit

[Michael J Gruber]

Anca Emanuel venit, vidit, dixit 02.03.2010 15:10:
> Hi, what do you think about Google Gerrit ? http://code.google.com/p/gerrit/
> 
> see it in action here: http://review.source.android.com
> 
> quote:
> "Gerrit is a web based code review system, facilitating online code
> reviews for projects using the Git version control system.
> Gerrit makes reviews easier by showing changes in a side-by-side
> display, and allowing inline comments to be added by any reviewer.
> Gerrit simplifies Git based project maintainership by permitting any
> authorized user to submit changes to the master Git repository, rather
> than requiring all approved changes to be merged in by hand by the
> project maintainer. This functionality enables a more centralized
> usage of Git."
> 
> git needs an friendly UI, web based is the future.

Maybe, one of the main Git guys here should look into it - such as the
one you cc'ed and who's one of the main Gerrit guys also?

Seriously, are you suggesting to use Gerrit for the management of
git.git (the Git source), or what is this post about? Also, please don't
crosspost. If you think kernel people should use Gerrit, post there only.

Michael

Re: Google Gerrit

[Anca Emanuel]

> Maybe, one of the main Git guys here should look into it - such as the
> one you cc'ed and who's one of the main Gerrit guys also?
>
> Seriously, are you suggesting to use Gerrit for the management of
> git.git (the Git source), or what is this post about? Also, please don't
> crosspost. If you think kernel people should use Gerrit, post there only.
>
> Michael
>

Hi, Michael:

I know the tools are not matured yet, this is just an buzz about.

But in the future, I like to see lkml on wave and remote servers for
testing online and in "real time", etc. It's a dream ?