From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] submodule summary: do not shift a non-existent positional variable
Date: Thu, 04 Mar 2010 00:12:37 +0100 [thread overview]
Message-ID: <201003040012.37412.johan@herland.net> (raw)
In-Reply-To: <1267654750-30911-1-git-send-email-gitster@pobox.com>
On Wednesday 03 March 2010, Junio C Hamano wrote:
> From: Jeff King <peff@peff.net>
>
> When "git submodule summary" is run without any argument, we default to
> compare the state of index with the HEAD, but tried to shift out $1 that
> does not exist (and worse yet, we didn't use it).
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Johan Herland <johan@herland.net>
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
prev parent reply other threads:[~2010-03-03 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 22:19 [PATCH 1/2] submodule summary: do not shift a non-existent positional variable Junio C Hamano
2010-03-03 22:19 ` [PATCH 2/2] submodule summary: do not fail before the first commit Junio C Hamano
2010-03-03 23:12 ` Johan Herland
2010-03-03 23:12 ` Johan Herland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003040012.37412.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).