From: Clemens Buchacher <drizzd@aon.at>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH v2 0/7] http: minor improvements
Date: Thu, 4 Mar 2010 21:38:11 +0100 [thread overview]
Message-ID: <20100304203811.GB5626@darc.dnsalias.org> (raw)
In-Reply-To: <1267526971-5552-1-git-send-email-rctay89@gmail.com>
On Tue, Mar 02, 2010 at 06:49:24PM +0800, Tay Ray Chuan wrote:
> Changes from v1 (based on comments from Clemens):
> - patch 3: don't say "remove condition", since we're actually enabling
> it.
> - patch 5: in keeping with separating http and http-walker, removed
> http_cleanup() from http-walker->cleanup().
> - patch 5: move http_cleanup() call after http-walker->cleanup(). This
> isn't really needed, but do this just in case http-walker->cleanup()
> does any http operations.
Thanks.
> [PATCH v2 1/7] t5541-http-push: check that ref is unchanged for non-ff test
> [PATCH v2 2/7] t554[01]-http-push: refactor, add non-ff tests
> [PATCH v2 3/7] http-push: remove "|| 1" to enable verbose check
> [PATCH v2 4/7] http-walker: cleanup more thoroughly
> [PATCH v2 5/7] http: init and cleanup separately from http-walker
> [PATCH v2 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper
> [PATCH v2 7/7] remote-curl: init walker only when needed
Acked-by: Clemens Buchacher <drizzd@aon.at>
prev parent reply other threads:[~2010-03-04 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 10:49 [PATCH v2 0/7] http: minor improvements Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 1/7] t5541-http-push: check that ref is unchanged for non-ff test Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 2/7] t554[01]-http-push: refactor, add non-ff tests Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 3/7] http-push: remove "|| 1" to enable verbose check Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 4/7] http-walker: cleanup more thoroughly Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 5/7] http: init and cleanup separately from http-walker Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 7/7] remote-curl: init walker only when needed Tay Ray Chuan
2010-03-04 20:38 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304203811.GB5626@darc.dnsalias.org \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).