From: Jonathan Nieder <jrnieder@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Steve Cotton <steve0001@s.cotton.clara.co.uk>,
Alexander Gavrilov <angavrilov@gmail.com>,
git@vger.kernel.org
Subject: [PATCH gitk 0/2] stop clobbering "Remember This View" setting
Date: Sat, 6 Mar 2010 16:46:05 -0600 [thread overview]
Message-ID: <20100306224605.GA7064@progeny.tock> (raw)
Hi Paul,
As Steve Cotton reported [1], the Edit View... dialog in gitk
always defaults to not remembering the view, which makes it
easy to lose settings if one is not careful.
These patches fix it. The first one adds two one-line comments
from my investigation into the issue. The second one fixes the
obvious bug.
I am cc-ing others in case I have missed anything obvious or
people have comments on style.
I hope you enjoy the patches.
Kind regards,
Jonathan Nieder (2):
gitk: Add comments to explain encode_view_opts and decode_view_opts
gitk: Edit View unsets Remember this view
gitk | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
[1] http://bugs.debian.org/522520
next reply other threads:[~2010-03-06 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 22:46 Jonathan Nieder [this message]
2010-03-06 22:48 ` [PATCH 1/2] gitk: Add comments to explain encode_view_opts and decode_view_opts Jonathan Nieder
2010-03-06 22:58 ` [PATCH 2/2] gitk: Stop clobbering "Remember This View" setting Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100306224605.GA7064@progeny.tock \
--to=jrnieder@gmail.com \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=steve0001@s.cotton.clara.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).