From: Dmitry Potapov <dpotapov@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com, torvalds@linux-foundation.org
Subject: Re: core.autocrlf considered half-assed
Date: Tue, 9 Mar 2010 13:11:01 +0300 [thread overview]
Message-ID: <20100309101101.GJ31105@dpotapov.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.1003091028440.7596@pacific.mpi-cbg.de>
On Tue, Mar 09, 2010 at 10:29:20AM +0100, Johannes Schindelin wrote:
>
> That is just papering over the real culprit: Git checks something out.
> This should be clean. But then Git says it is not.
We have two filters: from-git-to-worktree and from-worktree-to-git. If
those conversions are inconsistent for whatever reason, it is not going
to be well even if we found a way to solve this not-being-clean-after-
checkout problem.
One possible approach is to mark all files that had CRLF conversion
during checkout and apply the opposite conversion only to them. But what
about newly added files? Wouldn't this lead that to the situation where
newly added files will have the incorrect ending?
IMHO, this not clean after checkout repo demonstrates that you have the
incorrectly crlf configuration in it. So, you probably should correct
.gitattributes (or even to disable autocrlf in it if this repository is
not intended to be used with autocrlf=true). Either way, your current
settings are incorrect. It is better to fix it than try to hide it!
Dmitry
prev parent reply other threads:[~2010-03-09 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 23:23 core.autocrlf considered half-assed Johannes Schindelin
2010-03-07 9:27 ` Dmitry Potapov
2010-03-07 23:45 ` Linus Torvalds
2010-03-08 18:57 ` Tait
2010-03-08 19:15 ` Johannes Schindelin
2010-03-08 20:31 ` Junio C Hamano
2010-03-09 9:28 ` Johannes Schindelin
2010-03-09 17:11 ` Junio C Hamano
2010-03-08 11:29 ` Johannes Schindelin
2010-03-09 7:24 ` Dmitry Potapov
2010-03-09 9:29 ` Johannes Schindelin
2010-03-09 10:11 ` Dmitry Potapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309101101.GJ31105@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).