From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2010, #02; Sun, 07)
Date: Tue, 9 Mar 2010 18:13:07 -0500 [thread overview]
Message-ID: <20100309231306.GD25265@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk4tnw4nz.fsf@alter.siamese.dyndns.org>
On Mon, Mar 08, 2010 at 01:20:32AM -0800, Junio C Hamano wrote:
> After thinking about this a bit more, I do not think it is a good idea to
> disable configured decoration when an explicit --pretty is given. A patch
> to do so would be a trivial two-liner:
> [...]
> but there is one big difference between notes and decoration. Decorations
> are designed to be a small, one-per-ref tokens that would sit well on a
> line that already has other essential informations, while notes are a lot
> louder "in your face" annotations that occupy line(s) on their own.
True, but turning off configured decorations also helps scripts. I think
we can all agree that normal "git log" is not supposed to be consumed by
scripts, but should "git log --pretty=raw" turn off configured
decorations?
With the current code, gitk (which calls "log --pretty=raw") barfs on a
repository with log.decorate turned on.
-Peff
next prev parent reply other threads:[~2010-03-09 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 22:49 What's cooking in git.git (Mar 2010, #02; Sun, 07) Junio C Hamano
2010-03-08 9:20 ` Junio C Hamano
2010-03-09 23:13 ` Jeff King [this message]
2010-03-10 0:58 ` Junio C Hamano
2010-03-10 19:59 ` Jeff King
2010-03-08 12:23 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309231306.GD25265@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).