git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* FEATURE REQUEST: sendemail.aliasesfile support enavironment variables and tilde
@ 2010-03-12 19:06 Jari Aalto
  2010-03-13  7:40 ` Jeff King
  0 siblings, 1 reply; 2+ messages in thread
From: Jari Aalto @ 2010-03-12 19:06 UTC (permalink / raw)
  To: git



It apperas that this is not possible with 1.7.0:

    # ~/.gitconfig
    [sendemail]
            aliasesfile = $HOME/.mailrc

=> opening $HOME/.mailrc: No such file or directory
ls -la $HOME/.mailrc
lrwxrwxrwx 1 root root 35 2008-05-31 11:08 /home/foo/.mailrc -> vc/git/shell-account-common/.mailrc


Neither seems to be "~/.mailrc" accpeted. Please add support for at
least tilde(~).

Jari

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: FEATURE REQUEST: sendemail.aliasesfile support enavironment variables and tilde
  2010-03-12 19:06 FEATURE REQUEST: sendemail.aliasesfile support enavironment variables and tilde Jari Aalto
@ 2010-03-13  7:40 ` Jeff King
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2010-03-13  7:40 UTC (permalink / raw)
  To: Jari Aalto; +Cc: git

On Fri, Mar 12, 2010 at 09:06:19PM +0200, Jari Aalto wrote:

> It apperas that this is not possible with 1.7.0:
> 
>     # ~/.gitconfig
>     [sendemail]
>             aliasesfile = $HOME/.mailrc
> 
> => opening $HOME/.mailrc: No such file or directory
> ls -la $HOME/.mailrc
> lrwxrwxrwx 1 root root 35 2008-05-31 11:08 /home/foo/.mailrc -> vc/git/shell-account-common/.mailrc
> 
> Neither seems to be "~/.mailrc" accpeted. Please add support for at
> least tilde(~).

If you (or anyone) are interested in writing the patch, it is as simple
as adding "--path" to the "git config" call for sendemail.aliasesfile.
Which unfortunately is not that simple, due to the way that sendemail
handles its config values, but the refactoring should not be too hard.

-Peff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-13  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-12 19:06 FEATURE REQUEST: sendemail.aliasesfile support enavironment variables and tilde Jari Aalto
2010-03-13  7:40 ` Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).