From: Jeff King <peff@peff.net>
To: Lars Damerow <lars@pixar.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add support for GIT_ONE_FILESYSTEM
Date: Mon, 15 Mar 2010 22:33:06 -0400 [thread overview]
Message-ID: <20100316023306.GA14253@coredump.intra.peff.net> (raw)
In-Reply-To: <20100315214003.GB11157@pixar.com>
On Mon, Mar 15, 2010 at 02:40:03PM -0700, Lars Damerow wrote:
> + if (getenv("GIT_ONE_FILESYSTEM") != NULL) {
Should this really trigger for GIT_ONE_FILESYSTEM=0? We already have
git_env_bool, which will handle 0/1, true/false, etc. Probably you
should use it here.
I am not a big fan of the environment variable name, either, but I don't
have another good suggestion. It is closely related to
GIT_CEILING_DIRECTORIES (in fact, you could probably solve the same
problem with GIT_CEILING_DIRECTORIES, but I think your solution is much
nicer in that it lets the user get away with being less verbose).
> + if (stat("..", &buf))
> + die_errno("failed to stat '..'");
> + if (buf.st_dev != current_device)
> + die("refusing to cross filesystem boundary '%s/..'", cwd);
> + }
I agree with Sverre that this message isn't descriptive enough, but I
like the suggestion you posted elsewhere in the thread.
-Peff
next prev parent reply other threads:[~2010-03-16 2:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 21:40 [PATCH] Add support for GIT_ONE_FILESYSTEM Lars Damerow
2010-03-15 23:16 ` Sverre Rabbelier
2010-03-15 23:36 ` Lars Damerow
2010-03-16 2:33 ` Jeff King [this message]
2010-03-16 3:28 ` Lars Damerow
2010-03-16 3:37 ` Jeff King
2010-03-16 4:19 ` Junio C Hamano
2010-03-16 5:56 ` Lars Damerow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316023306.GA14253@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=lars@pixar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).