git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: egit-dev@eclipse.org
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	"Lay, Stefan" <stefan.lay@sap.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [egit-dev] Translation of reflog messages?
Date: Fri, 19 Mar 2010 10:42:01 +0100	[thread overview]
Message-ID: <201003191042.01536.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <20100319040420.GA14689@spearce.org>

fredagen den 19 mars 2010 05.04.20 skrev  Shawn O. Pearce:
> "Lay, Stefan" <stefan.lay@sap.com> wrote:
> > Do we need to externalize reflog messages?
> >
> > We proposed a change to externalize all translatable Strings in egit.core
> > (http://egit.eclipse.org/r/#change,332). It contains code that writes to
> > the reflog, for example in BranchOperation:
> >
> > RefUpdate u = repository.updateRef(Constants.HEAD);
> > u.setRefLogMessage("checkout: moving to " + refName, false);
> >
> > Is this message subject to translation? Or maybe only part of it, namely
> > the name of the git command "checkout"? Are there tools which parse the
> > reflog message and rely on standardized texts?
> 
> Nope.  Currently nobody relies on the format of the message part of a
> reflog record.  So translating them should not break an application.

> Since these are strictly local to the repository, it probably makes
> sense to translate these messages for the user, so they make sense
> to them when they are reading a reflog history in some sort of
> browser UI.
> 
> I say, translate them.

On the other hand we try to use the same format as C git, which doesn't 
translate. Keeping the current messages and trying to translate on read is
another option. Be careful to translate only those parts that can be 
positively identified, so some pattern matching is required.  

If the contents of the reflog is translated before putting it there we destroy
all ability for people to make ad-hoc use of it using . I occasionally grep 
the log and a mix of swedish and english makes that much harder.

(Cc:ing the Git ML)

-- robin

           reply	other threads:[~2010-03-19  9:42 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20100319040420.GA14689@spearce.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003191042.01536.robin.rosenberg@dewire.com \
    --to=robin.rosenberg@dewire.com \
    --cc=egit-dev@eclipse.org \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=stefan.lay@sap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).