git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: "Carlos Rica" <jasampler@gmail.com>, "Santi Béjar" <santi@agolina.net>
Subject: [PATCH 4/5] tag -v: Do not spawn a separate process for verify-tag
Date: Sat, 20 Mar 2010 00:14:14 -0500	[thread overview]
Message-ID: <20100320051414.GD24791@progeny.tock> (raw)
In-Reply-To: <20100320050953.GA24746@progeny.tock>

Aside from handling of SIGPIPE, there was no reason for verify-tag
to run in a separate process.

Not much advantage to this I can see.  It just simplifies things
a little.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 builtin/tag.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/builtin/tag.c b/builtin/tag.c
index d56c882..d138e0c 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -147,11 +147,7 @@ static int delete_tag(const char *name, const char *ref,
 static int verify_tag(const char *name, const char *ref,
 				const unsigned char *sha1)
 {
-	const char *argv_verify_tag[] = {"git", "verify-tag",
-					"-v", "SHA1_HEX", NULL};
-	argv_verify_tag[3] = sha1_to_hex(sha1);
-
-	if (run_command_v_opt(argv_verify_tag, 0))
+	if (verify_tag_signature(sha1_to_hex(sha1), 1))
 		return error("could not verify the tag '%s'", name);
 	return 0;
 }
-- 
1.7.0.2

  parent reply	other threads:[~2010-03-20  5:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  5:09 [PATCH/RFC 0/5] libify verify_tag() Jonathan Nieder
2010-03-20  5:11 ` [PATCH 1/5] tag -v: use ‘git verify-tag’ without dash Jonathan Nieder
2010-03-20 16:01   ` Johannes Sixt
2010-03-20 21:29     ` Jonathan Nieder
2010-03-20  5:12 ` [PATCH 2/5] verify-tag: use sigchain library to block SIGPIPE Jonathan Nieder
2010-03-20  5:13 ` [PATCH 3/5] Expose verify_tag() Jonathan Nieder
2010-03-20  5:14 ` Jonathan Nieder [this message]
2010-03-20 22:14   ` [PATCH 4/5 v2] tag -v: Do not spawn a separate process for verify-tag Jonathan Nieder
2010-03-20  5:14 ` [PATCH 5/5] verify_tag_signature(): let caller look up tag object sha1 Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100320051414.GD24791@progeny.tock \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jasampler@gmail.com \
    --cc=santi@agolina.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).