From: Jonathan Nieder <jrnieder@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org, "Frédéric Brière" <fbriere@fbriere.net>
Subject: Re: [PATCH] gitk: Skip over AUTHOR/COMMIT_DATE when searching all fields
Date: Sat, 20 Mar 2010 01:42:48 -0500 [thread overview]
Message-ID: <20100320064248.GA26648@progeny.tock> (raw)
In-Reply-To: <1268607549-3440-1-git-send-email-fbriere@fbriere.net>
Frédéric Brière wrote:
> This prevents searches on "All Fields" from matching against the
> author/commit timestamps. Not only are these timestamps not searchable
> by themselves, but the displayed format will not match the query string
> anyway.
>
> Signed-off-by: Frédéric Brière <fbriere@fbriere.net>
Reviewed-and-tested-by: Jonathan Nieder <jrnieder@gmail.com>
There’s a follow-up patch to remove the duplicated code this touches
(no functional changes) at <http://bugs.debian.org/465776>.
Thanks again.
Jonathan
prev parent reply other threads:[~2010-03-20 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 22:59 [PATCH] gitk: Skip over AUTHOR/COMMIT_DATE when searching all fields Frédéric Brière
2010-03-20 6:42 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320064248.GA26648@progeny.tock \
--to=jrnieder@gmail.com \
--cc=fbriere@fbriere.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).