From: Fredrik Kuivinen <frekui@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: [PATCH 2/2] Make sha1_to_hex thread-safe
Date: Tue, 23 Mar 2010 18:31:30 +0100 [thread overview]
Message-ID: <20100323173130.GC4218@fredrik-laptop> (raw)
In-Reply-To: <20100323161713.3183.57927.stgit@fredrik-laptop>
Signed-off-by: Fredrik Kuivinen <frekui@gmail.com>
---
hex.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/hex.c b/hex.c
index bb402fb..fe1d302 100644
--- a/hex.c
+++ b/hex.c
@@ -1,5 +1,9 @@
#include "cache.h"
+#ifndef NO_PTHREADS
+#include <pthread.h>
+#endif
+
const signed char hexval_table[256] = {
-1, -1, -1, -1, -1, -1, -1, -1, /* 00-07 */
-1, -1, -1, -1, -1, -1, -1, -1, /* 08-0f */
@@ -48,6 +52,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1)
return 0;
}
+#ifdef NO_PTHREADS
char *sha1_to_hex(const unsigned char *sha1)
{
static int bufno;
@@ -65,3 +70,51 @@ char *sha1_to_hex(const unsigned char *sha1)
return buffer;
}
+#else
+static pthread_once_t sha1_to_hex_once = PTHREAD_ONCE_INIT;
+static pthread_key_t sha1_to_hex_key;
+
+static void sha1_to_hex_init(void)
+{
+ int err = pthread_key_create(&sha1_to_hex_key, free);
+ if (err)
+ die("pthread_key_create failed: %s", strerror(err));
+}
+
+struct sha1_to_hex_buf
+{
+ int no;
+ char hex[4][50];
+};
+
+char *sha1_to_hex(const unsigned char *sha1)
+{
+ static const char hex[] = "0123456789abcdef";
+ struct sha1_to_hex_buf *hexbuf;
+ int i;
+ char *buffer, *buf;
+
+ pthread_once(&sha1_to_hex_once, sha1_to_hex_init);
+
+ hexbuf = pthread_getspecific(sha1_to_hex_key);
+ if (!hexbuf) {
+ int err;
+ hexbuf = xmalloc(sizeof(struct sha1_to_hex_buf));
+ hexbuf->no = 0;
+ err = pthread_setspecific(sha1_to_hex_key, hexbuf);
+ if (err)
+ die("pthread_getspecific failed: %s", strerror(err));
+ }
+
+ buffer = hexbuf->hex[3 & ++hexbuf->no], buf = buffer;
+
+ for (i = 0; i < 20; i++) {
+ unsigned int val = *sha1++;
+ *buf++ = hex[val >> 4];
+ *buf++ = hex[val & 0xf];
+ }
+ *buf = '\0';
+
+ return buffer;
+}
+#endif
next prev parent reply other threads:[~2010-03-23 17:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100323161713.3183.57927.stgit@fredrik-laptop>
2010-03-23 17:31 ` [PATCH 1/2] Make xmalloc and xrealloc thread-safe Fredrik Kuivinen
2010-03-23 18:43 ` Shawn O. Pearce
2010-03-23 21:21 ` Fredrik Kuivinen
2010-03-23 23:50 ` Nicolas Pitre
2010-03-24 15:23 ` Fredrik Kuivinen
2010-03-24 17:53 ` Nicolas Pitre
2010-03-24 18:22 ` Shawn Pearce
2010-03-24 18:44 ` Junio C Hamano
2010-03-24 18:54 ` Nicolas Pitre
2010-03-24 19:57 ` Shawn Pearce
2010-03-24 20:22 ` [PATCH] " Nicolas Pitre
2010-03-24 20:28 ` Shawn O. Pearce
2010-03-24 21:02 ` Nicolas Pitre
2010-03-24 21:11 ` Junio C Hamano
2010-03-24 21:28 ` Junio C Hamano
2010-03-27 13:26 ` Fredrik Kuivinen
2010-03-27 18:59 ` Nicolas Pitre
2010-03-31 6:57 ` Fredrik Kuivinen
2010-04-07 2:57 ` [PATCH v2] " Nicolas Pitre
2010-04-07 3:16 ` Shawn O. Pearce
2010-04-07 4:51 ` Nicolas Pitre
2010-04-07 12:29 ` Shawn Pearce
2010-04-07 13:17 ` Nicolas Pitre
2010-04-07 14:30 ` Shawn Pearce
2010-04-07 14:47 ` Nicolas Pitre
2010-04-07 14:45 ` Fredrik Kuivinen
2010-04-07 15:08 ` Nicolas Pitre
2010-04-07 16:13 ` Fredrik Kuivinen
2010-04-07 16:44 ` Erik Faye-Lund
2010-04-07 18:37 ` Nicolas Pitre
2010-04-07 15:27 ` Sverre Rabbelier
2010-04-07 16:15 ` Fredrik Kuivinen
2010-04-07 16:17 ` Junio C Hamano
2010-04-07 18:49 ` Johannes Sixt
2010-04-08 7:15 ` [PATCH] Thread-safe xmalloc and xrealloc needs a recursive mutex Johannes Sixt
2010-04-08 8:42 ` Fredrik Kuivinen
2010-04-07 5:21 ` [PATCH v2] Make xmalloc and xrealloc thread-safe Junio C Hamano
2010-03-23 17:31 ` Fredrik Kuivinen [this message]
2010-03-23 20:23 ` [PATCH 2/2] Make sha1_to_hex thread-safe Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323173130.GC4218@fredrik-laptop \
--to=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).