From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Alexander Gladysh <agladysh@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Stephan Beyer <s-beyer@gmx.net>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: [RFC/PATCH 4/5] merge: make function try_merge_command non static
Date: Thu, 25 Mar 2010 05:58:16 +0100 [thread overview]
Message-ID: <20100325045818.14832.7391.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20100325045519.14832.65964.chriscool@tuxfamily.org>
and while at it let's move declaration of checkout_fast_forward()
into "merge-recursive.h" instead of "cache.h"
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
builtin/merge.c | 4 ++--
cache.h | 3 ---
merge-recursive.h | 4 ++++
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index f163d53..fc240f9 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -548,8 +548,8 @@ static void write_tree_trivial(unsigned char *sha1)
die("git write-tree failed to write a tree");
}
-static int try_merge_command(const char *strategy, struct commit_list *common,
- const char *head_arg, struct commit_list *remotes)
+int try_merge_command(const char *strategy, struct commit_list *common,
+ const char *head_arg, struct commit_list *remotes)
{
const char **args;
int i = 0, x = 0, ret;
diff --git a/cache.h b/cache.h
index ded3090..f7e501e 100644
--- a/cache.h
+++ b/cache.h
@@ -1056,7 +1056,4 @@ void overlay_tree_on_cache(const char *tree_name, const char *prefix);
char *alias_lookup(const char *alias);
int split_cmdline(char *cmdline, const char ***argv);
-/* builtin/merge.c */
-int checkout_fast_forward(const unsigned char *from, const unsigned char *to);
-
#endif /* CACHE_H */
diff --git a/merge-recursive.h b/merge-recursive.h
index be8410a..8640c00 100644
--- a/merge-recursive.h
+++ b/merge-recursive.h
@@ -53,4 +53,8 @@ int merge_recursive_generic(struct merge_options *o,
void init_merge_options(struct merge_options *o);
struct tree *write_tree_from_memory(struct merge_options *o);
+/* builtin/merge.c */
+int checkout_fast_forward(const unsigned char *from, const unsigned char *to);
+int try_merge_command(const char *strategy, struct commit_list *common, const char *head_arg, struct commit_list *remotes);
+
#endif
--
1.7.0.2.398.g89bc8ce
next prev parent reply other threads:[~2010-03-25 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 4:58 [RFC/PATCH 0/5] add a --strategy option to "git cherry-pick" Christian Couder
2010-03-25 4:58 ` [RFC/PATCH 1/5] revert: use strbuf to refactor the code that writes the merge message Christian Couder
2010-03-25 4:58 ` [RFC/PATCH 2/5] revert: refactor merge recursive code into its own function Christian Couder
2010-03-25 4:58 ` [RFC/PATCH 3/5] merge: refactor code that calls "git merge-STRATEGY" Christian Couder
2010-03-25 4:58 ` Christian Couder [this message]
2010-03-25 4:58 ` [RFC/PATCH 5/5] revert: add "--strategy" option to choose merge strategy Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325045818.14832.7391.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=agladysh@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).