Git development
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: gitster@pobox.com, git@vger.kernel.org,
	Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH] t0005: add test for trap handling from deeply nested function calls
Date: Fri, 26 Mar 2010 21:19:45 +0100	[thread overview]
Message-ID: <201003262119.45110.j6t@kdbg.org> (raw)
In-Reply-To: <vm2zHZjrZOha7LnIM_9fAEAvwVZrJtZlAI9f2XI_VUsdqr51ihAMW68a5BT9tvMdRDSqk6GYlSE@cipher.nrlssc.navy.mil>

On Freitag, 26. März 2010, Brandon Casey wrote:
> +test_expect_success 'trap triggered in deeply nested function works
> correctly' ' +	(atrap () { exit 0; }
> +	 func3 () { exit 1; }
> +	 func2 () { func3; }
> +	 func1 () { trap atrap EXIT; func2; }
> +	 func1)
> +'

What do you want to achieve with this test? That /usr/xpg4/bin/sh is not used 
on Solaris?

If git-bisect triggers this bug in /usr/xpg4/bin/sh and if this is our shell 
of choice on Solaris, wouldn't it be better to work around it in git-bisect?

-- Hannes

  parent reply	other threads:[~2010-03-26 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 16:34 [PATCH] t0005: add test for trap handling from deeply nested function calls Brandon Casey
2010-03-26 20:10 ` Junio C Hamano
2010-03-26 20:19 ` Johannes Sixt [this message]
2010-03-27  0:24   ` Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003262119.45110.j6t@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=casey@nrlssc.navy.mil \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox