From: "Shawn O. Pearce" <spearce@spearce.org>
To: git <git@vger.kernel.org>, mike.lifeguard@gmail.com
Subject: Tree with leading '0' modes in 1.7.0.3
Date: Fri, 26 Mar 2010 14:56:00 -0700 [thread overview]
Message-ID: <20100326215600.GA10910@spearce.org> (raw)
Mike (CC'd) found a bad Git tree today, where the modes for subtrees
where formatted using a leading '0':
$ od -c tree
0000000 1 0 0 6 4 4 R E A D M E \0 244 \r
0000020 233 214 350 375 0 263 374 227 264 343 $ 031 027 ` 373 301
0000040 ! h 0 4 0 0 0 0 m o d u l e s
0000060 \0 262 z K 240 4 377 \ 245 C c " 231 377 \n t
0000100 , \n O R E 0 4 0 0 0 0 s t e w
0000120 a r d b o t \0 037 \b 5 262 345 234 034 303 C
0000140 373 335 207 300 u 341 277 \f ] 320 207
0000153
The '0' on the 3rd line after '! h' is wrong. It shouldn't be here.
Likewise the '0' on the 5th line after "O R E" is also wrong.
At least its consistently broken. But its still broken by fsck
standards:
$ git fsck --full a39aa6d
warning in tree a39aa6d4a6dcfd6c14d8f818bbdf1dfcb3e11771: contains zero-padded file modes
Mike claims this tree was created with git-core 1.7.0.3. This thread
actually started over on Gerrit Code Review's mailing list [1],
because JGit refuses to allow this malformed tree mode to pass its
fsck implementation.
Any ideas? Why is Git 1.7.0.3 jamming a leading '0' on a file mode?
[1] https://groups.google.com/group/repo-discuss/browse_thread/thread/6ff8d7ffba5a9775
--
Shawn.
next reply other threads:[~2010-03-26 21:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 21:56 Shawn O. Pearce [this message]
2010-03-26 22:26 ` Tree with leading '0' modes in 1.7.0.3 Jonathan Nieder
2010-03-26 22:29 ` Shawn O. Pearce
2010-03-26 22:40 ` Jonathan Nieder
2010-03-26 23:09 ` Junio C Hamano
2010-03-26 22:59 ` Mike.lifeguard
2010-03-26 23:05 ` Shawn O. Pearce
2010-03-26 23:22 ` Mike.lifeguard
2010-03-26 23:49 ` Jonathan Nieder
2010-03-26 23:50 ` Junio C Hamano
2010-03-26 23:56 ` Avery Pennarun
2010-03-27 0:00 ` Mike.lifeguard
2010-03-27 1:22 ` Shawn O. Pearce
2010-03-27 1:30 ` Nicolas Pitre
2010-03-27 1:34 ` Shawn O. Pearce
2010-03-27 1:56 ` Nicolas Pitre
2010-03-27 2:33 ` Avery Pennarun
2010-03-27 12:44 ` Scott Chacon
2010-03-27 14:21 ` Nicolas Pitre
2010-03-27 19:14 ` Shawn O. Pearce
2010-03-27 19:30 ` A Large Angry SCM
2010-03-27 19:32 ` Shawn O. Pearce
2010-03-27 19:39 ` A Large Angry SCM
2010-03-27 19:44 ` A Large Angry SCM
2010-03-27 19:57 ` A Large Angry SCM
2010-03-28 17:38 ` Sitaram Chamarty
2010-03-28 23:28 ` A Large Angry SCM
2010-03-27 20:13 ` A Large Angry SCM
2010-03-27 20:16 ` Junio C Hamano
2010-03-27 22:16 ` Avery Pennarun
2010-03-27 5:16 ` Junio C Hamano
2010-03-27 19:20 ` Shawn O. Pearce
2010-03-27 20:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326215600.GA10910@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=mike.lifeguard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).