From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: Tree with leading '0' modes in 1.7.0.3
Date: Fri, 26 Mar 2010 18:22:11 -0700
Message-ID: <20100327012211.GD10910@spearce.org>
References: <20100326215600.GA10910@spearce.org> <20100326222659.GA18369@progeny.tock> <20100326222950.GB10910@spearce.org> <4BAD3C6E.4090604@gmail.com> <20100326230537.GC10910@spearce.org> <7v7hoyabiv.fsf@alter.siamese.dyndns.org> <32541b131003261656h430d77a8q753c6141297e8f86@mail.gmail.com> <4BAD4A82.5070703@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avery Pennarun <apenwarr@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Scott Chacon <schacon@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>, git <git@vger.kernel.org>
To: "Mike.lifeguard" <mike.lifeguard@gmail.com>
X-From: git-owner@vger.kernel.org Sat Mar 27 02:22:25 2010
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@lo.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1NvKjG-0000Db-1n
	for gcvg-git-2@lo.gmane.org; Sat, 27 Mar 2010 02:22:22 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754161Ab0C0BWQ (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Fri, 26 Mar 2010 21:22:16 -0400
Received: from mail-gw0-f46.google.com ([74.125.83.46]:44706 "EHLO
	mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754118Ab0C0BWP (ORCPT <rfc822;git@vger.kernel.org>);
	Fri, 26 Mar 2010 21:22:15 -0400
Received: by gwaa18 with SMTP id a18so2979487gwa.19
        for <git@vger.kernel.org>; Fri, 26 Mar 2010 18:22:14 -0700 (PDT)
Received: by 10.90.60.12 with SMTP id i12mr1278075aga.119.1269652934000;
        Fri, 26 Mar 2010 18:22:14 -0700 (PDT)
Received: from localhost (george.spearce.org [209.20.77.23])
        by mx.google.com with ESMTPS id 21sm1294966iwn.3.2010.03.26.18.22.12
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Fri, 26 Mar 2010 18:22:12 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4BAD4A82.5070703@gmail.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/143309>

"Mike.lifeguard" <mike.lifeguard@gmail.com> wrote:
> On 10-03-26 08:56 PM, Avery Pennarun wrote:
> > The problem is that everything in git works perfectly with these
> > invalid file modes *except* fsck, and there's rarely a need to run
> > fsck, so this problem can hide for a long time.
> 
> So, does the error matter or not? If it doesn't matter, then shouldn't
> Jgit stop whining? If it does, then whatever-it-is needs to be fixed.

Its less harmful than other types of corruption.  But its quite
wrong from a format perspective. The hash of the tree differs even
though there is no semantic difference in the tree content.

Given that GitHub has blessed the world with this corruption,
we may need to modify JGit to accept it.

-- 
Shawn.