From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] grep: Add the option '--open-files-in-pager'
Date: Sat, 27 Mar 2010 23:09:38 -0500 [thread overview]
Message-ID: <20100328040938.GA2017@progeny.tock> (raw)
In-Reply-To: <alpine.DEB.1.00.1003261149040.7596@pacific.mpi-cbg.de>
Hi,
Johannes Schindelin wrote:
> This adds an option to open the matching files in the pager, and if the
> pager happens to be "less" (or "vi") and there is only one grep pattern,
> it also jumps to the first match right away.
Sounds interesting.
> diff --git a/builtin-grep.c b/builtin-grep.c
> index 5d83d9b..233c772 100644
I couldn’t get this to apply to current master or maint, and searching for
blob 5d83d9b to find a more suitable merge base revealed that I don’t
actually have that object in my repo. Is this patch available already
applied in a public git repo somewhere?
Hopeful,
Jonathan
next prev parent reply other threads:[~2010-03-28 4:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 10:48 [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-03-26 10:49 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Johannes Schindelin
2010-03-28 4:09 ` Jonathan Nieder [this message]
2010-03-29 17:13 ` Johannes Schindelin
2010-03-29 18:17 ` Junio C Hamano
2010-03-26 10:49 ` [PATCH 2/2] grep -P: allow optional argument specifying the pager (or editor) Johannes Schindelin
2010-03-26 10:50 ` Johannes Schindelin
2010-03-26 11:39 ` [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Bert Wesarg
2010-03-26 16:18 ` Johannes Schindelin
2010-03-26 20:07 ` Bert Wesarg
2010-03-26 12:46 ` Jeff King
2010-03-26 16:14 ` Johannes Schindelin
2010-03-26 20:33 ` Jeff King
2010-03-26 19:32 ` Junio C Hamano
2010-03-26 20:50 ` Francis Moreau
2010-03-27 1:09 ` Junio C Hamano
2010-03-27 15:19 ` Francis Moreau
2010-03-27 17:23 ` Junio C Hamano
2010-03-27 20:29 ` Francis Moreau
2010-03-26 19:49 ` Jon Seymour
-- strict thread matches above, loose matches on Subject: below --
2010-06-05 0:51 [PATCH v2 " Jonathan Nieder
2010-06-05 0:53 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-05 1:40 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100328040938.GA2017@progeny.tock \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).