From: Jeff King <peff@peff.net>
To: "Lars R. Damerow" <lars@pixar.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM
Date: Sun, 28 Mar 2010 08:05:32 -0400 [thread overview]
Message-ID: <20100328120532.GA6131@coredump.intra.peff.net> (raw)
In-Reply-To: <20100328092253.GA17563@coredump.intra.peff.net>
On Sun, Mar 28, 2010 at 05:22:54AM -0400, Jeff King wrote:
> > --- a/setup.c
> > +++ b/setup.c
> > @@ -390,6 +392,11 @@ const char *setup_git_directory_gently(int *nongit_ok)
> > * etc.
> > */
> > offset = len = strlen(cwd);
> > + if ((one_filesystem = git_env_bool("GIT_ONE_FILESYSTEM", 0))) {
> > + if (stat(".", &buf))
> > + die_errno("failed to stat '.'");
> > + current_device = buf.st_dev;
> > + }
>
> Style nit. I know you did the proper () to silence the compiler warning,
> but we usually avoid assignment-inside-conditional altogether.
> Personally I don't really care either way.
Actually I take this back. It is in our CodingStyle guide, but we
violate it all over the place (my grep counted 522). Perhaps it should
be removed from CodingStyle.
-Peff
next prev parent reply other threads:[~2010-03-28 12:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 19:55 [PATCH v3 0/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-17 19:55 ` [PATCH 1/3] config.c: remove static keyword from git_env_bool() Lars R. Damerow
2010-03-17 19:55 ` [PATCH 2/3] truncate cwd string before printing error message Lars R. Damerow
2010-03-17 19:55 ` [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-28 9:22 ` Jeff King
2010-03-28 12:05 ` Jeff King [this message]
2010-03-28 16:44 ` Junio C Hamano
2010-03-28 17:32 ` Lars Damerow
2010-03-30 15:58 ` Jeff King
2010-03-30 22:43 ` Linus Torvalds
2010-03-30 22:59 ` Thomas Rast
2010-03-30 23:04 ` Jeff King
2010-03-30 23:02 ` Jeff King
2010-03-30 23:10 ` Junio C Hamano
2010-03-30 23:12 ` Linus Torvalds
2010-03-31 0:54 ` Erik Faye-Lund
2010-04-04 18:00 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
2010-04-04 22:30 ` [PATCH] Rename ONE_FILESYSTEM to DISCOVERY_ACROSS_FILESYSTEM Junio C Hamano
2010-04-04 22:37 ` Matthieu Moy
2010-04-04 22:39 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100328120532.GA6131@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=lars@pixar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).