From: Johan Herland <johan@herland.net>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Makefile: Remove usage of deprecated Python "has_key" method
Date: Mon, 29 Mar 2010 04:16:40 +0200 [thread overview]
Message-ID: <201003290416.40774.johan@herland.net> (raw)
In-Reply-To: <1269737112-21631-1-git-send-email-davvid@gmail.com>
On Sunday 28 March 2010, David Aguilar wrote:
> "has_key" is a deprecated dictionary method in Python 2.6+.
> Simplify the sys.path manipulation for installed scripts by
> passing a default value to os.getenv().
>
> SCRIPT_PYTHON is currently empty but this future-proofs us.
> It also fixes things for users who maintain local git forks
> with their own SCRIPT_PYTHON additions.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
Acked-by: Johan Herland <johan@herland.net>
--
Johan Herland, <johan@herland.net>
www.herland.net
prev parent reply other threads:[~2010-03-29 2:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 0:45 [PATCH] Makefile: Remove usage of deprecated Python "has_key" method David Aguilar
2010-03-28 16:38 ` Junio C Hamano
2010-03-28 21:54 ` David Aguilar
2010-03-29 0:23 ` Tay Ray Chuan
2010-03-29 4:08 ` Junio C Hamano
2010-03-29 2:16 ` Johan Herland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003290416.40774.johan@herland.net \
--to=johan@herland.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).