From: "Stephen R. van den Berg" <srb@cuci.nl>
To: "Henrik Grubbstr??m (Grubba)" <grubba@grubba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] convert: Keep foreign $Id$ on checkout.
Date: Mon, 29 Mar 2010 14:48:36 +0200 [thread overview]
Message-ID: <20100329124836.GE22480@cuci.nl> (raw)
In-Reply-To: <6d9d8b0eaa022f441c507b141ff0efa3f21d1988.1269860022.git.grubba@grubba.org>
Henrik Grubbstr??m (Grubba) wrote:
>If there are foreign $Id$ keywords in the repository, they are most
>likely there for a reason. Let's keep them on checkout (which is also
>what the documentation indicates). Foreign $Id$ keywords are now
>recognized by there being multiple space separated fields in $Id:xxxxx$.
>Signed-off-by: Henrik Grubbstr??m <grubba@grubba.org>
>---
>The typical use case is for repositories that have been converted
>from some other VCS, where it is desirable to keep the old identifiers
>around until there's some other reason to alter the file.
Looks good.
Acked-By: Stephen R. van den Berg <srb@cuci.nl>
--
Stephen.
next prev parent reply other threads:[~2010-03-29 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 11:28 [PATCH 0/5] ident attribute related patches (resend w/ testsuite v3) Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 1/5] convert: Safer handling of $Id$ contraction Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 2/5] convert: Keep foreign $Id$ on checkout Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 3/5] convert: Use the enum constant SAFE_CRLF_FALSE Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 4/5] convert: Inhibit contraction of foreign $Id$ during stats Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 5/5] convert: Added core.refilteronadd feature Henrik Grubbström (Grubba)
2010-03-29 12:54 ` Stephen R. van den Berg
2010-03-29 12:51 ` [PATCH 4/5] convert: Inhibit contraction of foreign $Id$ during stats Stephen R. van den Berg
2010-04-01 19:56 ` Junio C Hamano
2010-04-06 11:53 ` Henrik Grubbström
2010-03-29 12:49 ` [PATCH 3/5] convert: Use the enum constant SAFE_CRLF_FALSE Stephen R. van den Berg
2010-04-01 19:53 ` Junio C Hamano
2010-03-29 12:48 ` Stephen R. van den Berg [this message]
2010-03-29 12:46 ` [PATCH 1/5] convert: Safer handling of $Id$ contraction Stephen R. van den Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329124836.GE22480@cuci.nl \
--to=srb@cuci.nl \
--cc=git@vger.kernel.org \
--cc=grubba@grubba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).