From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCHv5 6/6] gitweb: update INSTALL to use shorter make target Date: Thu, 1 Apr 2010 14:25:29 +0200 Message-ID: <201004011425.29869.jnareb@gmail.com> References: <4BB43105.7000201@mailservices.uwaterloo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, Junio C Hamano To: Mark Rada X-From: git-owner@vger.kernel.org Thu Apr 01 14:25:44 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NxJSx-0006Oy-Ka for gcvg-git-2@lo.gmane.org; Thu, 01 Apr 2010 14:25:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755977Ab0DAMZh (ORCPT ); Thu, 1 Apr 2010 08:25:37 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:55804 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755783Ab0DAMZf (ORCPT ); Thu, 1 Apr 2010 08:25:35 -0400 Received: by bwz1 with SMTP id 1so794908bwz.21 for ; Thu, 01 Apr 2010 05:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=rFAnlt/nCnsjZsxiWkBWYAjUk6TvspknPJMd1xrWZgk=; b=OgV+T+Cj5/OaEMY3nmV7hlm9EXBM3KuPaXdZoNDmDkG7jLu6GAG/4BNuMce3WNADl2 Ynwc4AziIu500OBC7+vI6AfIsS+uvQsIgyvzcgjWOk54zoUY0xWNgJWxC7z2+nNKdEWz DsB5pqpbGwQSi302TOGkMjzGUfRFwY+ikSysM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=KRIRmd6qtxTG4MmG7o67HsO2P4IESJux88kr9I00hOEkmnVlvq17dGO3T62ICLBLCF uU7doAqRCVLoP1Gut2/D/KWf33QQR8Ey11zM4SBwcdfXl0MgrPPgrRte/HmHpgwgZT9C WTQDvTurH28152jNtbcltky/daZ5/jDI7RiXM= Received: by 10.204.151.71 with SMTP id b7mr1349690bkw.114.1270124733966; Thu, 01 Apr 2010 05:25:33 -0700 (PDT) Received: from [192.168.1.13] (abws156.neoplus.adsl.tpnet.pl [83.8.242.156]) by mx.google.com with ESMTPS id 15sm4185956bwz.4.2010.04.01.05.25.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 01 Apr 2010 05:25:32 -0700 (PDT) User-Agent: KMail/1.9.3 In-Reply-To: <4BB43105.7000201@mailservices.uwaterloo.ca> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, 1 Apr 2010, Mark Rada wrote: > Gitweb can be generated by the gitweb/gitweb.cgi target or the gitweb > target. Since the gitweb target is shorter, I think it would be better > to have new users be instructed to use it. Good idea. > - $ make prefix=/usr gitweb/gitweb.cgi ;# as yourself > + $ make prefix=/usr gitweb.cgi ;# as yourself > # cp gitweb/git* /var/www/cgi-bin/ ;# as root But it should read - $ make prefix=/usr gitweb/gitweb.cgi ;# as yourself + $ make prefix=/usr gitweb ;# as yourself The target is "gitweb", not "gitweb.cgi" > Alternatively you can use autoconf generated ./configure script to > @@ -16,7 +15,7 @@ instead > > $ make configure ;# as yourself > $ ./configure --prefix=/usr ;# as yourself > - $ make gitweb/gitweb.cgi ;# as yourself > + $ make gitweb.cgi ;# as yourself Same here. > @@ -86,7 +84,7 @@ Build example > GITWEB_LOGO="/gitweb/git-logo.png" \ > GITWEB_FAVICON="/gitweb/git-favicon.png" \ > bindir=/usr/local/bin \ > - gitweb/gitweb.cgi > + gitweb.cgi Same here. Also spaces in place of TAB. -- Jakub Narebski Poland