git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Dustin Sallings <dustin@spy.net>
Cc: git@vger.kernel.org
Subject: Re: git describe bug?
Date: Fri, 2 Apr 2010 11:31:47 -0700	[thread overview]
Message-ID: <20100402183147.GA20007@spearce.org> (raw)
In-Reply-To: <0B8BD2B7-E6F9-4EFC-BCD6-2B2E876AD1FC@spy.net>

Dustin Sallings <dustin@spy.net> wrote:
> 
> 	describe does not choose the most recent tag when multiple tags point to a single commit (for example, when an RC release becomes a proper release).
> 
> 	There's a bit of conflict in the documentation between the following:
> 
> 		``tags with newer dates will always be preferred over tags with older dates''
> 
> 	and the next sentence:
> 
> 		``If an exact match is found, its name will be output and searching will stop.''
> 
> 	The code does not allow for multiple exact matches, leading to what I would consider incorrect behavior as shown below:

Yes, I've seen this too.  IIRC we've actually discussed this in
the past.  I can't find the thread (my search skills are sub-par
despite who I work for...).  But the general idea if I remember
it right was we wanted to use the older tag, because that tag
came first.

So its probably more a documentation bug than a software bug.

-- 
Shawn.

  reply	other threads:[~2010-04-02 18:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02 17:20 git describe bug? Dustin Sallings
2010-04-02 18:31 ` Shawn O. Pearce [this message]
2010-04-06  9:48   ` Andreas Ericsson
2010-04-11  0:28     ` Shawn O. Pearce
2010-04-11  1:54       ` [PATCH] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-11  2:36         ` Junio C Hamano
2010-04-11  2:40           ` Shawn O. Pearce
2010-04-12 23:25             ` [PATCH v2 1/5] tag.c: Correct indentation Shawn O. Pearce
2010-04-12 23:25             ` [PATCH v2 2/5] tag.h: Remove unused signature field Shawn O. Pearce
2010-04-12 23:25             ` [PATCH v2 3/5] tag.c: Refactor parse_tag_buffer to be saner to program Shawn O. Pearce
2010-04-12 23:25             ` [PATCH v2 4/5] tag.c: Parse tagger date (if present) Shawn O. Pearce
2010-04-12 23:25             ` [PATCH v2 5/5] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-13  9:27               ` Andreas Ericsson
2010-04-13  9:32               ` Thomas Rast
2010-04-13 14:08                 ` Shawn O. Pearce
2010-04-13 19:26                   ` Junio C Hamano
2010-04-13 19:46                     ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100402183147.GA20007@spearce.org \
    --to=spearce@spearce.org \
    --cc=dustin@spy.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).