From: Jeff King <peff@peff.net>
To: Markus Heidelberg <markus.heidelberg@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] git status: refresh the index
Date: Fri, 2 Apr 2010 17:21:20 -0400 [thread overview]
Message-ID: <20100402212120.GA28352@coredump.intra.peff.net> (raw)
In-Reply-To: <201004022237.04130.markus.heidelberg@web.de>
On Fri, Apr 02, 2010 at 09:37:03PM +0100, Markus Heidelberg wrote:
> > Does this mean we will fail to run in a read-only repository?
>
> You're right.
> But that was already the case when "status" was "commit --dry-run".
> I have to admit, I didn't think about this scenario, but simply looked
> for the differences between these two commands.
Sort of. See ab68545 (status: don't require the repository to be
writable, 2010-01-19), which went onto maint while the "status is no
longer commit --dry-run" topic was cooking elsewhere. So I think it
would be a regression from 1.6.6.2 onwards.
At any rate, I think we all agree on what it _should_ do, so if you're
willing to do an updated patch, that would be great. The patch from
ab68545 may be helpful, as the code it changed is quite similar to what
you posted in this series.
-Peff
next prev parent reply other threads:[~2010-04-02 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 12:27 [PATCH 0/4] fix regression that "git status" doesn't refresh the index Markus Heidelberg
2010-04-02 12:27 ` [PATCH 1/4] builtin/commit: fix duplicated sentence in a comment Markus Heidelberg
2010-04-02 12:27 ` [PATCH 2/4] builtin/commit: remove unnecessary variable definition Markus Heidelberg
2010-04-02 12:27 ` [PATCH 3/4] t7508: add test for "git status" refreshing the index Markus Heidelberg
2010-04-02 12:27 ` [PATCH 4/4] git status: refresh " Markus Heidelberg
2010-04-02 16:57 ` Jeff King
2010-04-02 20:37 ` Markus Heidelberg
2010-04-02 21:21 ` Jeff King [this message]
2010-04-02 18:56 ` Junio C Hamano
2010-04-02 20:39 ` Markus Heidelberg
2010-04-02 21:44 ` [PATCH v2 4/4] git status: refresh the index if possible Markus Heidelberg
2010-04-03 4:33 ` Junio C Hamano
2010-04-03 10:11 ` [PATCH] t7508: add a test for "git status" in a read-only repository Markus Heidelberg
2010-04-06 6:20 ` Junio C Hamano
2010-04-03 10:33 ` [PATCH v2 4/4] git status: refresh the index if possible Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402212120.GA28352@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).