git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Chris Webb <chris@arachsys.com>,
	Sverre Rabbelier <srabbelier@gmail.com>
Subject: Tests with broken && chains in pu
Date: Sun, 4 Apr 2010 22:08:58 +0200	[thread overview]
Message-ID: <201004042208.58939.j6t@kdbg.org> (raw)

Junio,

two commits in pu currently add tests with broken && chains:

abbfd017 in cw/ws-indent-with-tab:

diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index 9e57f80..e92eab0 100755
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
@@ -354,7 +354,7 @@ test_expect_success 'check tabs and spaces as indentation (indent-with-non-tab:
 
 test_expect_success 'check tabs as indentation (tab-in-indent: off)' '
 
-	git config core.whitespace "-tab-in-indent"
+	git config core.whitespace "-tab-in-indent" &&
 	echo "	foo ();" > x &&
 	git diff --check
 
@@ -378,7 +378,7 @@ test_expect_success 'check tabs and spaces as indentation (tab-in-indent: on)' '
 
 test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '
 
-	git config core.whitespace "tab-in-indent,indent-with-non-tab"
+	git config core.whitespace "tab-in-indent,indent-with-non-tab" &&
 	echo "foo ();" > x &&
 	test_must_fail git diff --check
 
@@ -386,7 +386,7 @@ test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '
 
 test_expect_success 'check tab-in-indent excluded from wildcard whitespace attribute' '
 
-	git config --unset core.whitespace
+	git config --unset core.whitespace &&
 	echo "x whitespace" > .gitattributes &&
 	echo "	  foo ();" > x &&
 	git diff --check &&



c8eeb6301 in sr/remote-helper-export

diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh
index 33f546b..eb31709 100755
--- a/t/t5800-remote-helpers.sh
+++ b/t/t5800-remote-helpers.sh
@@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'
 
 test_expect_success 'setup repository' '
 	git init --bare server/.git &&
-	git clone server public
+	git clone server public &&
 	(cd public &&
 	 echo content >file &&
 	 git add file &&
@@ -18,7 +18,7 @@ test_expect_success 'setup repository' '
 '
 
 test_expect_success 'cloning from local repo' '
-	git clone "testgit::${PWD}/server" localclone
+	git clone "testgit::${PWD}/server" localclone &&
 	test_cmp public/file localclone/file
 '
 

             reply	other threads:[~2010-04-04 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-04 20:08 Johannes Sixt [this message]
2010-04-04 20:15 ` Tests with broken && chains in pu Sverre Rabbelier
2010-04-04 20:41   ` Johannes Sixt
2010-04-04 20:45 ` Chris Webb
2010-04-04 21:28 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004042208.58939.j6t@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=chris@arachsys.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).