From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eelis van der Weegen <eelis@eelis.net>,
Paul Mackerras <paulus@samba.org>, Miles Bader <miles@gnu.org>
Subject: Re: [PATCH 1/2] diff: add --word-diff option that generalizes --color-words
Date: Mon, 5 Apr 2010 12:20:46 +0200 [thread overview]
Message-ID: <201004051220.47400.trast@student.ethz.ch> (raw)
In-Reply-To: <7v39zay7or.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
>
> I think it is a bug that "git show --word-diff" gives the colored format
> output when I have "color.ui" configuration.
>
> Even though I may have "color.ui = auto" in the configuration, I am
> telling the command to do a --word-diff, not --color-words, from the
> command line, and that should override color.ui settings.
I don't really see why the user would forfeit the convenience and
readability of a color-words diff when the terminal supports colors.
Granted, this is probably the first instance where the colors actually
change the output format instead of just making easier to read, but
still?
But:
> It might be just the matter of defaulting --word-diff without "=<type>"
> not to "auto" but to "plain". I haven't looked at the code closely yet.
Yes.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-04-05 10:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1269996525.git.trast@student.ethz>
2010-04-04 13:46 ` [PATCH 0/2] gitk --color-words Thomas Rast
2010-04-04 13:46 ` [PATCH 1/2] diff: add --word-diff option that generalizes --color-words Thomas Rast
2010-04-05 2:06 ` Junio C Hamano
2010-04-05 10:20 ` Thomas Rast [this message]
2010-04-05 18:46 ` Junio C Hamano
2010-04-05 18:53 ` Miles Bader
2010-04-12 13:07 ` [PATCH v3 0/2] gitk --color-words Thomas Rast
2010-04-12 13:07 ` [PATCH v3 1/3] diff: add --word-diff option that generalizes --color-words Thomas Rast
2010-04-12 16:31 ` Junio C Hamano
2010-04-13 9:27 ` Thomas Rast
2010-04-14 15:59 ` [PATCH v4 0/3] git-diff --word-diff/gitk --color-words Thomas Rast
2010-04-14 15:59 ` [PATCH v4 1/3] diff: add --word-diff option that generalizes --color-words Thomas Rast
2010-04-14 21:23 ` Junio C Hamano
2010-04-14 15:59 ` [PATCH v4 2/3] gitk: do not parse " >" context as submodule change Thomas Rast
2010-04-15 19:57 ` Jens Lehmann
2010-04-17 6:33 ` Paul Mackerras
2010-04-17 12:20 ` Thomas Rast
2010-04-19 1:08 ` Paul Mackerras
2010-04-19 16:27 ` [PATCH v4' 1/2] " Thomas Rast
2010-04-19 16:27 ` [PATCH v4' 2/2] gitk: add the equivalent of diff --color-words Thomas Rast
2010-04-19 17:22 ` [PATCH v4' 1/2] gitk: do not parse " >" context as submodule change Jens Lehmann
2010-04-20 17:05 ` Jens Lehmann
2010-04-14 15:59 ` [PATCH v4 3/3] gitk: add the equivalent of diff --color-words Thomas Rast
2010-04-17 6:35 ` Paul Mackerras
2010-04-17 6:55 ` Junio C Hamano
2010-04-12 13:07 ` [PATCH v3 2/3] gitk: do not parse " >" context as submodule change Thomas Rast
2010-04-12 13:25 ` [PATCH v3.1] " Thomas Rast
2010-04-12 13:07 ` [PATCH v3 3/3] gitk: add the equivalent of diff --color-words Thomas Rast
2010-04-06 9:20 ` [PATCH 1/2] diff: add --word-diff option that generalizes --color-words Thomas Rast
2010-04-04 13:46 ` [PATCH 2/2] gitk: add the equivalent of diff --color-words Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004051220.47400.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=eelis@eelis.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=miles@gnu.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).