From: Jonathan Nieder <jrnieder@gmail.com>
To: A Large Angry SCM <gitzilla@gmail.com>
Cc: Alexander Gladysh <agladysh@gmail.com>,
git@vger.kernel.org, Markus Heidelberg <markus.heidelberg@web.de>,
Avery Pennarun <apenwarr@gmail.com>
Subject: Re: [PATCH/RFC] gitk: refresh index before checking for local changes
Date: Tue, 6 Apr 2010 21:57:06 -0500 [thread overview]
Message-ID: <20100407025706.GA6528@progeny.tock> (raw)
In-Reply-To: <4BBBEC43.5000100@gmail.com>
A Large Angry SCM wrote:
[context: should gitk run ‘gitk update-index --refresh -q’ transparently?]
> NAK - gitk should not modify a repository and/or working dir unless
> _explicitly_ prompted to by the user.
>
> If you want a new _non-default_ option setting for gitk, that fine also.
I have some sympathy for this point of view.
Does the same principle apply to ‘git diff’? If not, why not?
It should be possible to suppress files with no changes from the
display without refreshing the index (or not to suppress them and to
still refresh the index, nor that matter; the issues are orthogonal),
but it would be nice to come up with a clear rationale first.
Jonathan
next prev parent reply other threads:[~2010-04-07 2:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:57 gitk pays too much attention to file timestamps Alexander Gladysh
2010-04-06 23:15 ` Markus Heidelberg
2010-04-06 23:36 ` Jonathan Nieder
2010-04-06 23:47 ` Alexander Gladysh
2010-04-07 0:43 ` [PATCH/RFC] gitk: refresh index before checking for local changes Jonathan Nieder
2010-04-07 1:07 ` Alexander Gladysh
2010-04-07 1:16 ` Jonathan Nieder
2010-04-07 2:21 ` A Large Angry SCM
2010-04-07 2:57 ` Jonathan Nieder [this message]
2010-04-07 5:47 ` Junio C Hamano
2010-04-07 11:21 ` A Large Angry SCM
2010-04-07 16:48 ` Avery Pennarun
2010-04-07 14:36 ` Jon Seymour
2010-04-06 23:58 ` gitk pays too much attention to file timestamps Avery Pennarun
2010-04-07 1:01 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407025706.GA6528@progeny.tock \
--to=jrnieder@gmail.com \
--cc=agladysh@gmail.com \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).