From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] ls-remote: default to 'origin' when no remote specified
Date: Thu, 8 Apr 2010 02:25:39 -0400 [thread overview]
Message-ID: <20100408062539.GC30473@coredump.intra.peff.net> (raw)
In-Reply-To: <7v8w8y8q1f.fsf@alter.siamese.dyndns.org>
On Wed, Apr 07, 2010 at 10:35:40PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I don't really see a problem with this. The current behavior produces an
> > error, so it is not as if we are breaking somebody's workflow, and the
> > only sensible default is the same one used by the other commands.
>
> I'd agree only if "the other commands" default to the same remote;
> otherwise as a plumbing, ls-remote should insist that the user be more
> explicit.
>
> The only odd-man out that would worry me is "git pull", as I expect
> everybody written in C would just use remote_get(NULL).
I agree, but I think they do all default to the same remote. Push and
fetch both use remote_get(NULL). Pull, AFAICT, just calls fetch and
picks out what to merge from FETCH_HEAD. Am I missing any others?
-Peff
next prev parent reply other threads:[~2010-04-08 6:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 3:58 [PATCH] ls-remote: default to 'origin' when no remote specified Tay Ray Chuan
2010-04-08 4:45 ` Jeff King
2010-04-08 5:35 ` Junio C Hamano
2010-04-08 6:25 ` Jeff King [this message]
2010-04-08 6:07 ` Tay Ray Chuan
2010-04-08 6:34 ` Jeff King
2010-04-08 6:44 ` Junio C Hamano
2010-04-08 6:47 ` Jeff King
2010-04-08 5:05 ` Junio C Hamano
2010-04-08 5:58 ` Tay Ray Chuan
2010-04-08 7:05 ` [PATCH v2] ls-remote: fall-back to default remotes " Tay Ray Chuan
2010-04-08 7:07 ` [PATCH v2 (resend)] " Tay Ray Chuan
2010-04-08 7:16 ` Jeff King
2010-04-08 17:10 ` Tay Ray Chuan
2010-04-08 17:21 ` [PATCH v3] " Tay Ray Chuan
2010-04-08 19:19 ` Jeff King
2010-04-09 8:49 ` Peter Kjellerstedt
2010-04-09 9:15 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408062539.GC30473@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).