git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@student.ethz.ch>,
	git@vger.kernel.org
Subject: Re: [PATCH] log: respect log.shownotes variable
Date: Thu, 8 Apr 2010 03:07:33 -0400	[thread overview]
Message-ID: <20100408070732.GI30473@coredump.intra.peff.net> (raw)
In-Reply-To: <4BBD390A.1030906@drmicha.warpmail.net>

On Thu, Apr 08, 2010 at 10:01:46AM +0800, Michael J Gruber wrote:

> BTW: I used to keep external notes in
> refs/remotes/remotename/notes/notestree but since a while ago the notes
> code insists on refs/notes/. In some sense it is similar to tags, where
> you need to set up special refspecs if you want to have the remote
> tags/notes but don't want to mix them (and possibly have them conflict)
> with your own. But I don't know a good strategy for making this more
> user friendly.

I always assumed that the "prepend refs/notes" magic would refuse to do
so if the ref started with "notes/" (in which case it would append
"refs/") or "refs/" (in which case it would append nothing). That is how
we handle some situations where a branch head or a remote could be
used.

But I never checked, so maybe it doesn't. It probably should.

-Peff

  reply	other threads:[~2010-04-08  7:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07 20:45 [PATCH] log: respect log.shownotes variable Jeff King
2010-04-07 21:53 ` Junio C Hamano
2010-04-08  2:01   ` Michael J Gruber
2010-04-08  7:07     ` Jeff King [this message]
2010-04-08  7:05   ` Jeff King
2010-04-08 16:12 ` Thomas Rast
2010-04-08 16:55   ` Junio C Hamano
2010-04-08 19:16   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408070732.GI30473@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).