Re: [PATCH] log: respect log.shownotes variable

[Thomas Rast <trast@student.ethz.ch>]

Jeff King wrote:
> Log shows notes by default if no --pretty format is given.
> However, depending on what's in your default notes ref, that
> may actually be quite distracting when reading a normal log.
> Let's let the user decide whether they want to see notes by
> default.

Looks useful to me, and the patch looks obviously correct.

> My git repository has your mailing list reference notes in
> refs/notes/commits. They're quite bulky, and being headers, they look
> kind of like a new commit stanza, which always confuses me when reading
> log output. I got tired of typing --no-notes.
> 
> I guess an alternate solution would be for me to store them in some
> other ref, and then use --show-notes=email when I do want to see them
> (instead of just --show-notes, as I would do with this patch). But I
> still wonder if log.shownotes is a sensible addition, just for the sake
> of completeness.

I think it is a useful addition, *especially* in the case where the
configuration departs from the default.  Typing --show-notes=email
--show-notes=commits just to avoid showing a third set of notes in
refs/notes/bulky will get old fairly quickly...

BTW, now that I seem to have a couple of users for those notes: what
would you like to see in the "short" version (notes/terse)?  Improving
that to be the "common" case has been on my todo list for quite some
time.  For example, I'm considering changing the 'permalink' to
'thread' so that access to the full thread is easier (you'll still
have to click the subject to find the root).  Also, the message text
snippets have been broken since I revived it in February, does anyone
miss them?  They made the output even bulkier.

Of course, I also hope that in the long run we can somehow generate
this from Junio's amlog for better accuracy :-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch