From: "Shawn O. Pearce" <spearce@spearce.org>
To: Andreas Ericsson <ae@op5.se>
Cc: Dustin Sallings <dustin@spy.net>, git@vger.kernel.org
Subject: Re: git describe bug?
Date: Sat, 10 Apr 2010 17:28:25 -0700 [thread overview]
Message-ID: <20100411002825.GA23075@spearce.org> (raw)
In-Reply-To: <4BBB0377.8080007@op5.se>
Andreas Ericsson <ae@op5.se> wrote:
> Right now the behaviour is inconsistent.
...
> So as you can see, something else is going on. Both tags here are
> stashed as loose objects and both refs are unpacked.
Its the order the names were iterated out of the directory by
readdir(). Or the order they were sorted by lexographical ordering
during for_each_ref(). I can't remember if for_each_ref() sorts
the items before processing.
But either describe uses the first item it found for a given commit
if they have the same priority. There's no notion of date being
factored into the decision of which tag to keep.
I'll work up a patch right now.
--
Shawn.
next prev parent reply other threads:[~2010-04-11 0:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 17:20 git describe bug? Dustin Sallings
2010-04-02 18:31 ` Shawn O. Pearce
2010-04-06 9:48 ` Andreas Ericsson
2010-04-11 0:28 ` Shawn O. Pearce [this message]
2010-04-11 1:54 ` [PATCH] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-11 2:36 ` Junio C Hamano
2010-04-11 2:40 ` Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 1/5] tag.c: Correct indentation Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 2/5] tag.h: Remove unused signature field Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 3/5] tag.c: Refactor parse_tag_buffer to be saner to program Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 4/5] tag.c: Parse tagger date (if present) Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 5/5] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-13 9:27 ` Andreas Ericsson
2010-04-13 9:32 ` Thomas Rast
2010-04-13 14:08 ` Shawn O. Pearce
2010-04-13 19:26 ` Junio C Hamano
2010-04-13 19:46 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100411002825.GA23075@spearce.org \
--to=spearce@spearce.org \
--cc=ae@op5.se \
--cc=dustin@spy.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).