From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Ericsson <ae@op5.se>, Dustin Sallings <dustin@spy.net>,
git@vger.kernel.org
Subject: Re: [PATCH] describe: Break annotated tag ties by tagger date
Date: Sat, 10 Apr 2010 19:40:08 -0700 [thread overview]
Message-ID: <20100411024008.GC23075@spearce.org> (raw)
In-Reply-To: <7vwrwera05.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > If more than one annotated tag points at the same commit, use the
> > tag whose tagger field has a more recent date stamp. This resolves
> > non-deterministic cases where the maintainer has done:
>
> I think it is a good idea to introduce this tiebreaker to give the listing
> some degree of stability. And I also notice that you prepared a patch
> that can easily apply to an older codebase like 1.6.6 maintenance track.
>
> I have anything against this as an incremental and low impact improvement,
> but at the same time I think we might want to consider adding the tagger
> date to "struct tag".
Yea, I thought about that. It would have simplified the code
in describe. But I was also trying to avoid a larger impact. :-)
I'm more than happy to respin with a new date field in struct tag.
I just won't be able to get to it before Monday.
--
Shawn.
next prev parent reply other threads:[~2010-04-11 2:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 17:20 git describe bug? Dustin Sallings
2010-04-02 18:31 ` Shawn O. Pearce
2010-04-06 9:48 ` Andreas Ericsson
2010-04-11 0:28 ` Shawn O. Pearce
2010-04-11 1:54 ` [PATCH] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-11 2:36 ` Junio C Hamano
2010-04-11 2:40 ` Shawn O. Pearce [this message]
2010-04-12 23:25 ` [PATCH v2 1/5] tag.c: Correct indentation Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 2/5] tag.h: Remove unused signature field Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 3/5] tag.c: Refactor parse_tag_buffer to be saner to program Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 4/5] tag.c: Parse tagger date (if present) Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 5/5] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-13 9:27 ` Andreas Ericsson
2010-04-13 9:32 ` Thomas Rast
2010-04-13 14:08 ` Shawn O. Pearce
2010-04-13 19:26 ` Junio C Hamano
2010-04-13 19:46 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100411024008.GC23075@spearce.org \
--to=spearce@spearce.org \
--cc=ae@op5.se \
--cc=dustin@spy.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).