From: "Shawn O. Pearce" <spearce@spearce.org>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 5/5] describe: Break annotated tag ties by tagger date
Date: Tue, 13 Apr 2010 07:08:30 -0700 [thread overview]
Message-ID: <20100413140830.GA12635@spearce.org> (raw)
In-Reply-To: <201004131132.30186.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> wrote:
> Shawn O. Pearce wrote:
> > If the tag is an older-style annotated tag with no tagger date,
> > we assume a date stamp of 1 second after the UNIX epoch.
>
> This patch doesn't seem to actually set this, but as a minor nit: the
> '1 second' contradicts the 0 mentioned in the last patch.
>
> (The effect is the same for all practical purposes.)
Whoops. Old commit message from v1. I skim read it knowing I
needed to adjust something in the message before reusing it, but
didn't see anything, so sent it as-is.
Junio, it might make sense to drop the part Thomas quoted above
before you apply this.
--
Shawn.
next prev parent reply other threads:[~2010-04-13 14:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 17:20 git describe bug? Dustin Sallings
2010-04-02 18:31 ` Shawn O. Pearce
2010-04-06 9:48 ` Andreas Ericsson
2010-04-11 0:28 ` Shawn O. Pearce
2010-04-11 1:54 ` [PATCH] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-11 2:36 ` Junio C Hamano
2010-04-11 2:40 ` Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 1/5] tag.c: Correct indentation Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 2/5] tag.h: Remove unused signature field Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 3/5] tag.c: Refactor parse_tag_buffer to be saner to program Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 4/5] tag.c: Parse tagger date (if present) Shawn O. Pearce
2010-04-12 23:25 ` [PATCH v2 5/5] describe: Break annotated tag ties by tagger date Shawn O. Pearce
2010-04-13 9:27 ` Andreas Ericsson
2010-04-13 9:32 ` Thomas Rast
2010-04-13 14:08 ` Shawn O. Pearce [this message]
2010-04-13 19:26 ` Junio C Hamano
2010-04-13 19:46 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413140830.GA12635@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).