From: Charles Bailey <charles@hashpling.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
Mark Rada <marada@uwaterloo.ca>,
git@vger.kernel.org
Subject: Re: [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css
Date: Thu, 15 Apr 2010 01:18:30 +0100 [thread overview]
Message-ID: <20100415001830.GA26416@hashpling.org> (raw)
In-Reply-To: <7viq7tmvsb.fsf@alter.siamese.dyndns.org>
On Wed, Apr 14, 2010 at 04:58:12PM -0700, Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > On Tue, 13 April 2010, Charles Bailey wrote:
> >> On 01/04/2010 06:36, Mark Rada wrote:
> >> > @@ -84,13 +92,14 @@ endif
> >> >
> >> > all:: gitweb.cgi
> >> >
> >> > +FILES = gitweb.cgi
> >> > ifdef JSMIN
> >> > +FILES += gitweb.min.js
> >> > +endif
> >> > +ifdef CSSMIN
> >> > +FILES += gitweb.min.css
> >> > +endif
> >> > +gitweb.cgi: gitweb.perl $(GITWEB_JS) $(GITWEB_CSS)
> >
> > GITWEB_JS and GITWEB_CSS were originally meant to be URI to file with
> > gitweb JavaScript code and default gitweb stylesheet,... but during work
> > on minification of JavaScript code and CSS file it somehow got confused
> > to mean source path.
>
> I am not touching instaweb part, but this would fix the build/clean side
> of the things, no?
>
Yes, this certainly fixes make and make clean for me with overridden
GITWEB_JS and GITWEB_CSS paths.
Charles.
next prev parent reply other threads:[~2010-04-15 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 5:36 [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css Mark Rada
2010-04-01 8:51 ` Jakub Narebski
2010-04-13 20:28 ` Charles Bailey
2010-04-13 22:30 ` Jakub Narebski
2010-04-14 5:40 ` Mark Rada
2010-04-14 17:22 ` Jakub Narebski
2010-04-14 19:17 ` Mark Rada
2010-04-14 20:04 ` Jakub Narebski
2010-04-14 23:58 ` Junio C Hamano
2010-04-15 0:18 ` Charles Bailey [this message]
2010-04-15 0:25 ` Jakub Narebski
2010-04-15 0:46 ` Junio C Hamano
2010-04-15 1:02 ` Jakub Narebski
2010-04-15 1:21 ` Mark Rada
2010-04-15 1:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415001830.GA26416@hashpling.org \
--to=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=marada@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).