git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line
Date: Thu, 15 Apr 2010 16:55:23 +0100	[thread overview]
Message-ID: <20100415155523.GL12365@arachsys.com> (raw)
In-Reply-To: <201004151735.31415.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> Have you read
> 
>   http://thread.gmane.org/gmane.comp.version-control.git/124082/focus=124092

I hadn't but have now. I don't buy the idea that this date is an unused
placeholder in mbox files, and therefore can be sensibly set to an arbitary
constant date in the distant past.

RFC4155 appendix A defines this date as the date a message was received.
This isn't directly applicable to the context of format-patch, but other
users of mbox format (e.g. MUAs doing an fcc) tend to fill it with the date
the message was generated, and might reasonably expect to be able to
sort on this date, e.g. when displaying a drafts folder.

If nothing else, it's extremely surprising to run format-patch, see a
ridiculous date and wonder how your system time has become corrupted while
you've been working!

Cheers,

Chris.

  reply	other threads:[~2010-04-15 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15 14:41 [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Chris Webb
2010-04-15 15:16 ` Chris Webb
2010-04-15 15:35   ` Thomas Rast
2010-04-15 15:55     ` Chris Webb [this message]
2010-04-17 18:16     ` Junio C Hamano
2010-04-15 15:57   ` [PATCH] Fix t4013 with current date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-15 23:19 ` [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Jonathan Nieder
2010-04-16  7:52   ` Chris Webb
2010-04-16 16:42     ` [PATCH v2 1/2] format-patch: use commit " Chris Webb
2010-04-16 16:42     ` [PATCH 2/2] Fix t4013 with commit date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-16 17:59       ` Santi Béjar
2010-04-17  8:01         ` [PATCH v3] format-patch: use commit date in mbox 'From COMMIT DATE' header line Chris Webb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100415155523.GL12365@arachsys.com \
    --to=chris@arachsys.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).