From: Thomas Rast <trast@student.ethz.ch>
To: Chris Webb <chris@arachsys.com>
Cc: Junio C Hamano <gitster@pobox.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line
Date: Thu, 15 Apr 2010 17:35:31 +0200 [thread overview]
Message-ID: <201004151735.31415.trast@student.ethz.ch> (raw)
In-Reply-To: <20100415151619.GK12365@arachsys.com>
Chris Webb wrote:
> Chris Webb <chris@arachsys.com> writes:
>
> > Put the current date in the 'From COMMIT DATE' header line instead of using
> > the fixed date 'Mon Sep 17 00:00:00 2001'. A DATE_UTC mode for show_date() is
> > introduced so we can easily generate this line in the correct format.
>
> ...but this will break t4013-diff-various which expects the exact date
> string 'Mon Sep 17 00:00:00 2001' in the mbox header. Patch to fix this test
> to follow!
Have you read
http://thread.gmane.org/gmane.comp.version-control.git/124082/focus=124092
Not that I really care either way, but you should at least convince us
why it is broken as it stands :-)
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-04-15 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 14:41 [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Chris Webb
2010-04-15 15:16 ` Chris Webb
2010-04-15 15:35 ` Thomas Rast [this message]
2010-04-15 15:55 ` Chris Webb
2010-04-17 18:16 ` Junio C Hamano
2010-04-15 15:57 ` [PATCH] Fix t4013 with current date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-15 23:19 ` [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Jonathan Nieder
2010-04-16 7:52 ` Chris Webb
2010-04-16 16:42 ` [PATCH v2 1/2] format-patch: use commit " Chris Webb
2010-04-16 16:42 ` [PATCH 2/2] Fix t4013 with commit date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-16 17:59 ` Santi Béjar
2010-04-17 8:01 ` [PATCH v3] format-patch: use commit date in mbox 'From COMMIT DATE' header line Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004151735.31415.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).