From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Avery Pennarun" <apenwarr@gmail.com>,
"David Martínez Martí" <desarrollo@gestiweb.com>,
git@vger.kernel.org, deavidsedice@gmail.com
Subject: Re: Possible bug in Git
Date: Fri, 16 Apr 2010 19:00:26 +0200 [thread overview]
Message-ID: <201004161900.26537.trast@student.ethz.ch> (raw)
In-Reply-To: <7vvdbrcp5g.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> There was already a "fix" posted for the "empty vs missing" confusion.
>
> From: Thomas Rast <trast@student.ethz.ch>
> Subject: [PATCH] combined diff: correctly handle truncated file
> Date: Thu, 15 Apr 2010 14:59:37 +0200
> Message-ID:
> <884b9b68a4478aceda580299c059a9a67417cb1c.1271336073.git.trast@student.ethz.ch>
>
> I've been busy for the past few days, but I have it in my 'to-maint'
> queue. We may actually want to do the same for "missing" case as well,
> though.
Why? The evil deletion is already reported as
diff --cc foo
index 5716ca5,7601807..0000000
deleted file mode 100644,100644
--- a/foo
+++ /dev/null
with no diff -- but the absence of a diff is because of your 4462731
(combine-diff: do not punt on removed or added files., 2006-02-06) and
I tend to agree with the reasoning.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2010-04-16 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 10:47 Possible bug in Git David Martínez Martí
2010-04-15 12:59 ` [PATCH] combined diff: correctly handle truncated file Thomas Rast
2010-04-15 23:45 ` Possible bug in Git Avery Pennarun
2010-04-16 0:01 ` Junio C Hamano
2010-04-16 0:06 ` Avery Pennarun
2010-04-16 0:13 ` Avery Pennarun
2010-04-16 0:38 ` Jay Soffian
2010-04-16 0:45 ` Avery Pennarun
2010-04-16 15:53 ` Linus Torvalds
2010-04-16 16:39 ` Thomas Rast
2010-04-16 16:56 ` Junio C Hamano
2010-04-16 17:00 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004161900.26537.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=apenwarr@gmail.com \
--cc=deavidsedice@gmail.com \
--cc=desarrollo@gestiweb.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).