From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH] revision: --ancestry-path
Date: Wed, 21 Apr 2010 09:34:30 +0200 [thread overview]
Message-ID: <201004210934.30226.johan@herland.net> (raw)
In-Reply-To: <7v39ypg4gm.fsf_-_@alter.siamese.dyndns.org>
On Wednesday 21 April 2010, Junio C Hamano wrote:
> This is somewhat a rough-cut, as I haven't thought through possible
> interactions this new option may have with "rev-list --parents" and
> "rev-list --graph" (see "NEEDSWORK" in revision.c), but I'll leave that
> to people who are more interested in this topic than myself ;-).
Thanks! :)
I can confirm that this patch works with my original (more complicated)
scenario. I've also played around with combinations of --ancestry-path, --
graph and --parents (and even --boundary), and AFAICS, the new option does
not clobber the other options, and (IMHO) it all behaves correctly in the
scenarios I've tested. Consider it:
Tested-by: Johan Herland <johan@herland.net>
I've also reviewed the patch, and it all looks good to me (i.e. "Acked-by",
except I'm not super-familiar in the relevant area of the code).
What more should I do to push this forwards towards 'next'?
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2010-04-21 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 14:49 Getting 'git log' (or something else) to show me the relevant sub-graph? Johan Herland
2010-04-20 15:18 ` Michael J Gruber
2010-04-20 20:45 ` Junio C Hamano
2010-04-20 22:10 ` [PATCH] revision: --ancestry-path Junio C Hamano
2010-04-21 7:34 ` Johan Herland [this message]
2010-04-21 7:47 ` Johannes Sixt
2010-04-21 8:01 ` Junio C Hamano
2010-04-21 8:19 ` [PATCH v2] " Junio C Hamano
2010-04-21 8:46 ` [PATCH] " Johan Herland
2010-04-21 9:04 ` Junio C Hamano
2010-04-21 8:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004210934.30226.johan@herland.net \
--to=johan@herland.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).